Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang warnings in Fireworks #25520

Merged
merged 3 commits into from Dec 20, 2018
Merged

Fix clang warnings in Fireworks #25520

merged 3 commits into from Dec 20, 2018

Commits on Dec 19, 2018

  1. Forward delcare FWCollectionSummaryWidgetConnectionHolder as a struct 

    This inconsistency was found by clang
    @Dr15Jones
    Dr15Jones committed Dec 19, 2018
    Copy the full SHA
    ad0aa78 View commit details
    Browse the repository at this point in the history

  2. Having using for base class build functions 

    This silences a clang warning.
    @Dr15Jones
    Dr15Jones committed Dec 19, 2018
    Copy the full SHA
    b42e2f9 View commit details
    Browse the repository at this point in the history

  3. Renamed fwPaletteClassic.cc to fwPaletteClassic.icc 

    The file fwPaletteClassic.cc was only being included into
FWCoreManager and defined some static values. clang was
issuing a warning for unused variables when fwPaletteClassic.cc
was compiled by itself. Changing the postfix will stop the file
from being compiled.
    @Dr15Jones
    Dr15Jones committed Dec 19, 2018
    Copy the full SHA
    de927e9 View commit details
    Browse the repository at this point in the history