Make sure named bins are unique in HLTObjectsMonitor #25569

Dr15Jones · 2018-12-28T16:09:11Z

In the newest version of ROOT, histograms with named bins are
merged via the bin's name, not the index. This means we must
avoid bins having the same bin names.
HLTObjectsMonitor has a histogram which uses path names for the
bin names. In the past, multiple bins could have the same path
name. This change guarantees uniqueness for the bin names and
only fills a bin once per event.

In the newest version of ROOT, histograms with named bins are merged via the bin's name, not the index. This means we must avoid bins having the same bin names. HLTObjectsMonitor has a histogram which uses path names for the bin names. In the past, multiple bins could have the same path name. This change guarantees uniqueness for the bin names and only fills a bin once per event.

cmsbuild · 2018-12-28T16:09:39Z

The code-checks are being triggered in jenkins.

Dr15Jones · 2018-12-28T16:10:30Z

This fixes issue #25463

cmsbuild · 2018-12-28T16:13:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25569/7800

Dr15Jones · 2018-12-28T16:13:51Z

please test

cmsbuild · 2018-12-28T16:13:53Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DQM/HLTEvF

@cmsbuild, @andrius-k, @kmaeshima, @schneiml, @Martin-Grunewald, @jfernan2, @fwyzard can you please review it and eventually sign? Thanks.
@mtosi this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2018-12-28T16:14:16Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32376/console Started: 2018/12/28 17:15

cmsbuild · 2018-12-28T17:37:16Z

-1

Tested at: 75f0ba2

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25569/32376/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM.log

150.0 step3

runTheMatrix-results/150.0_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018/step3_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

136.85 step3

runTheMatrix-results/136.85_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018A+RunEGamma2018A+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Prompt_L1TEgDQM+HARVEST2018_L1TEgDQM.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017.log

11624.0 step3

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019+ALCAFull_2019.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

cmsbuild · 2018-12-28T17:37:20Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2019-01-08T12:03:15Z

+1
Tested at: 576b9cb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25569/32459/summary.html

cmsbuild · 2019-01-08T12:03:21Z

Comparison job queued.

cmsbuild · 2019-01-08T13:15:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25569/32459/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3153717
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 5
DQMHistoTests: Total successes: 3153506
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1.1 KiB( 32 files compared)
DQMHistoSizes: changed ( 1330.0,... ): -0.055 KiB HLT/Objects
Checked 137 log files, 14 edm output root files, 33 DQM output files

fabiocos · 2019-01-09T08:21:22Z

@Martin-Grunewald @fwyzard @andrius-k as discussed at the ORP, it would be good to have possible feedback from the HLT DQM whether these changes may be quickly tested with a replay of the online configurations, before technically merging them

Martin-Grunewald · 2019-01-10T08:33:20Z

@fabiocos
In principle this is fine with me but I personally would not be able to perform the test...
@gennai

gennai · 2019-01-10T08:37:47Z

@Martin-Grunewald has I wrote in a mail thread, I am afraid the only person who could perform such a test is @mtosi

fwyzard · 2019-01-10T09:12:51Z

isn't (wasn't ?) testing the online DQM more under the hat of FOG than of STEAM ?

Dr15Jones · 2019-01-17T13:49:49Z

Ping, not resolving this pull request is hampering our ability to move to a new version of ROOT.

Martin-Grunewald · 2019-01-18T08:21:05Z

+1
Not to block the new version of ROOT.

cmsbuild · 2019-01-18T08:21:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-01-18T16:17:52Z

@Martin-Grunewald thanks, I think it still would be useful to perform a test before discovering issues in two years from now. Not being particularly pressed this can be scheduled at some moment,. but it would be good not to forget it

fabiocos · 2019-01-18T16:18:56Z

+1

fioriNTU · 2019-02-27T16:08:32Z

@Dr15Jones , am I getting right that this PR solve issue #25463 ? If this is the case I will close the issue

Dr15Jones · 2019-02-27T16:34:25Z

One of the comments in this pull requests says it solves #25463, so I assume it is correct (it has been so long that I no longer remember).

cmsbuild added this to the CMSSW_10_5_X milestone Dec 28, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending hlt-pending orp-pending pending-signatures tests-pending labels Dec 28, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 28, 2018

cmsbuild added tests-started and removed tests-pending labels Dec 28, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Dec 28, 2018

Properly increment bin counter

a06dff9

cmsbuild added code-checks-pending and removed code-checks-approved comparison-notrun tests-rejected labels Dec 28, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 8, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jan 8, 2019

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Jan 18, 2019

cmsbuild added orp-approved and removed orp-pending labels Jan 18, 2019

cmsbuild merged commit 380d56b into cms-sw:master Jan 18, 2019

fabiocos mentioned this pull request Jan 18, 2019

Verify that uniqueness of named bins is not spoiling HLT monitoring #25702

Closed

Dr15Jones deleted the uniqueBinNamesHLTObjectsMonitor branch January 23, 2019 16:41

mmusich mentioned this pull request Nov 1, 2022

gemChamberVFATBX0GENeg11 with duplicate labels makes T0 crash on 12_5 reply #39936

Closed

nickh2000 mentioned this pull request Nov 1, 2022

EMTF DQM fix to remove duplicate x-axis bin labels #39952

Merged

mmusich mentioned this pull request Nov 2, 2022

[12.5.X] EMTF DQM fix to remove duplicate x-axis bin labels #39957

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure named bins are unique in HLTObjectsMonitor #25569

Make sure named bins are unique in HLTObjectsMonitor #25569

Dr15Jones commented Dec 28, 2018

cmsbuild commented Dec 28, 2018

Dr15Jones commented Dec 28, 2018

cmsbuild commented Dec 28, 2018

Dr15Jones commented Dec 28, 2018

cmsbuild commented Dec 28, 2018

cmsbuild commented Dec 28, 2018 •

edited

cmsbuild commented Dec 28, 2018

cmsbuild commented Dec 28, 2018

cmsbuild commented Jan 8, 2019

cmsbuild commented Jan 8, 2019

cmsbuild commented Jan 8, 2019

fabiocos commented Jan 9, 2019

Martin-Grunewald commented Jan 10, 2019

gennai commented Jan 10, 2019

fwyzard commented Jan 10, 2019

Dr15Jones commented Jan 17, 2019

Martin-Grunewald commented Jan 18, 2019

cmsbuild commented Jan 18, 2019

fabiocos commented Jan 18, 2019

fabiocos commented Jan 18, 2019

fioriNTU commented Feb 27, 2019

Dr15Jones commented Feb 27, 2019

Make sure named bins are unique in HLTObjectsMonitor #25569

Make sure named bins are unique in HLTObjectsMonitor #25569

Conversation

Dr15Jones commented Dec 28, 2018

cmsbuild commented Dec 28, 2018

Dr15Jones commented Dec 28, 2018

cmsbuild commented Dec 28, 2018

Dr15Jones commented Dec 28, 2018

cmsbuild commented Dec 28, 2018

cmsbuild commented Dec 28, 2018 • edited

cmsbuild commented Dec 28, 2018

cmsbuild commented Dec 28, 2018

cmsbuild commented Jan 8, 2019

cmsbuild commented Jan 8, 2019

cmsbuild commented Jan 8, 2019

fabiocos commented Jan 9, 2019

Martin-Grunewald commented Jan 10, 2019

gennai commented Jan 10, 2019

fwyzard commented Jan 10, 2019

Dr15Jones commented Jan 17, 2019

Martin-Grunewald commented Jan 18, 2019

cmsbuild commented Jan 18, 2019

fabiocos commented Jan 18, 2019

fabiocos commented Jan 18, 2019

fioriNTU commented Feb 27, 2019

Dr15Jones commented Feb 27, 2019

cmsbuild commented Dec 28, 2018 •

edited