Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_4_X) #25627

Merged
merged 27 commits into from Jan 22, 2019
Merged

Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_4_X) #25627

merged 27 commits into from Jan 22, 2019

Commits on Jan 11, 2019

  1. migrate 4d vertexing to fullsim and first mostly working version of t… 

    …ime of flight particle id
    @bendavid
    bendavid committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    4e931ba View commit details
    Browse the repository at this point in the history

  2. add protection for infinite loop in 4d vertex reco

    @bendavid
    bendavid committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    37d52b0 View commit details
    Browse the repository at this point in the history

  3. migrate PFCandidate times to fullsim/reconstruction

    @bendavid
    bendavid committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    dcc3ba2 View commit details
    Browse the repository at this point in the history

  4. produce also fastsim-based 4d vertices for now

    @bendavid
    bendavid committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    c67a838 View commit details
    Browse the repository at this point in the history

  5. tweak pid algorithm and add some configurable parameters

    @bendavid
    bendavid committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    45044c4 View commit details
    Browse the repository at this point in the history

  6. rearrange RecoVertex configuration for timing era so that 4d vertices… 

    … populate the default offlinePrimaryVertices collections
    @bendavid
    bendavid committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    55a63a3 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. remove beamspot from TOFPIDProducer (not used for the moment)

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    cf497e7 View commit details
    Browse the repository at this point in the history

  2. fix input collections for validation sequence

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    cf034b0 View commit details
    Browse the repository at this point in the history

  3. fix computation of vertex time uncertainty

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    d876f1e View commit details
    Browse the repository at this point in the history

  4. add outlier rejection for use of timing information in 4d vertex reco… 

    …nstruction
    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    3e8fa74 View commit details
    Browse the repository at this point in the history

  5. inflate uncertainty on track times to account for ambiguity in mass h… 

    …ypothesis at low momentum
    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    77f35f4 View commit details
    Browse the repository at this point in the history

  6. update logic and settings in TOFPIDProducer to produce an additional … 

    …safe t0 and sigmat0 output which protects the downstream 4d vertex reconstruction from outliers by keeping inflated uncertainties for tracks with ambiguous particle id
    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    b179203 View commit details
    Browse the repository at this point in the history

  7. code cleanup and review

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    dd355b9 View commit details
    Browse the repository at this point in the history

  8. add primary vertex configuration for mtd to separate file

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    b5081fb View commit details
    Browse the repository at this point in the history

  9. add fillDescriptions to TOFPIDProducer

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    9b7a4d9 View commit details
    Browse the repository at this point in the history

  10. add helper functions to fill value maps

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    047292f View commit details
    Browse the repository at this point in the history

  11. make outlier rejection remove tracks entirely rather than just drop t… 

    …iming info
    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    338db46 View commit details
    Browse the repository at this point in the history

  12. tune parameters for particle id

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    e0649ca View commit details
    Browse the repository at this point in the history

  13. further improvements to vertex time uncertainty calculation

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    7eb101e View commit details
    Browse the repository at this point in the history

  14. address further code review

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f6f308a View commit details
    Browse the repository at this point in the history

  15. make sure phase2_timing era (fastsim only for MTD) is still functional

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    2f7eabf View commit details
    Browse the repository at this point in the history

  16. fix broken import

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    121c67a View commit details
    Browse the repository at this point in the history

  17. fix typo in default input collections

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    40e5805 View commit details
    Browse the repository at this point in the history

  18. cleanup imports and modifications

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    eaa2b5a View commit details
    Browse the repository at this point in the history

  19. revert to standard 3D vertices for default collections

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    6a410e0 View commit details
    Browse the repository at this point in the history

  20. add additional slimmed primary vertex collection to miniaod with timing

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f6586dc View commit details
    Browse the repository at this point in the history

  21. split 4D vertices into separate cfi file

    @bendavid
    bendavid committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    75d66ac View commit details
    Browse the repository at this point in the history