Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_4_X)

[bendavid]

Backport of #25628

[cmsbuild]

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_10_4_X.

It involves the following packages:

CommonTools/RecoAlgos
RecoMTD/TrackExtender
RecoParticleFlow/PFProducer
RecoVertex/Configuration
RecoVertex/PrimaryVertexProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @GiacomoSguazzoni, @mmarionncern, @jhgoh, @lgray, @ahinzmann, @gkasieczka, @bachtis, @cbernet, @ebrondol, @VinInn, @rovere, @dgulhan, @seemasharmafnal, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_5_X) #25628

[slava77]

@cmsbuild please test

[slava77]

assign upgrade

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32537/console Started: 2019/01/11 18:29

[slava77]

@bendavid
please provide a PR for the master branch, which will be reviewed first.

[bendavid]

Master version is here
#25628

[kpedro88]

backport of #25628

[cmsbuild]

-1

Tested at: 55a63a3

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d65593d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25627/32537/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25627/32537/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25627/32537/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
27434.0 step3

runTheMatrix-results/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d65593d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25627/32537/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25627/32537/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #25627 was updated. @perrotta, @andrius-k, @kmaeshima, @schneiml, @kpedro88, @cmsbuild, @jfernan2, @slava77, @santocch can you please check and sign again.

[cmsbuild]

+1
Tested at: 75d66ac
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25627/32695/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25627/32695/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 38 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 362
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153151
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #25627 75d66ac

• code changes are the same as in the master version (Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_5_X) #25628 bbff806 )
• jenkins tests pass and comparisons with the baseline show differences only in the affected MTD workflow 27434

[fabiocos]

@andrius-k @kpedro88 as for master

[andrius-k]

+1

[fabiocos]

@kpedro88 I move forward with integration in order to speed up the release, as this looks the correct backport of what already approved in master. Please sign it in case for reference

[fabiocos]

+1

[fabiocos]

merge

[kpedro88]

@fabiocos usually I wait to sign backports until they have survived in a master IB, in case of surprises...

[fabiocos]

@kpedro88 I agree that this is the normal meaningful procedure, as here we are quite late I tried to get prepared in case of success, given that 10_4_X is dedicated only to this particular purpose and nothing else. Anyway as you may see in master this is not the end of the story...