added pull_request_template.md

[smuzaffar]

Added new Pull Request template which should be presented to the pull request submitter at the time of PR creation.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25848/8303

• This PR adds an extra 8KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

pull_request_template.md

The following packages do not have a category, yet:

pull_request_template.md
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

Pull request #25848 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

[fabiocos]

@smuzaffar the other messages printed by the bot are stored in the bot repository itself, like https://github.com/cms-sw/cms-bot/blob/master/cms_static.py
Is there a reason that I am missing why this addition should sit in CMSSW?

[smuzaffar]

@fabiocos , other messages are comments added by bot after the creation of PR.
This change will allow developer to see this message during the creation of PR. This message will be presented in the initial PR comment by github itself (See an example of PR here https://github.com/smuzaffar/cmssw/pull/9 )

[fabiocos]

@smuzaffar ok, I see the reason, it refers to the instructions https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/

So what are your integration plans? We should obviously add this file I would say to the core list in categories_map.py in cms-bot, I was about to do it today but I had this question before

[smuzaffar]

@fabiocos , @Dr15Jones feel free to update the contents of this PR. Should be add all L2's to sign this ( so that they are aware of the change)?

[fabiocos]

@smuzaffar I would perhaps modify "code contains tests relevant for the problem you are solving" into "code if possible contains tests relevant for the problem you are solving", as this does not necessarily always applies.
Fine for me to add all the categories, so everybody can comment and be aware

[fabiocos]

assign hlt,visualization,upgrade,generators,reconstruction,dqm,fastsim,db,alca,daq,xpog,pdmv,geometry,analysis,simulation,l1

[cmsbuild]

New categories assigned: fastsim,visualization,upgrade,xpog,pdmv,geometry,hlt,db,analysis,alca,generators,daq,reconstruction,l1,dqm,simulation

@Dr15Jones,@Dr15Jones,@andrius-k,@tocheng,@alberto-sanchez,@cvuosalo,@schneiml,@ianna,@kpedro88,@Martin-Grunewald,@jfernan2,@prebello,@zhenhu,@mommsen,@slava77,@ggovi,@perrozzi,@rekovic,@nsmith-,@efeyazgan,@pohsun,@emeschi,@qliphy,@peruzzim,@kmaeshima,@civanch,@civanch,@civanch,@alja,@pgunnell,@ssekmen,@franzoni,@perrotta,@santocch,@fgolf,@mdhildreth,@mdhildreth,@mdhildreth,@fwyzard,@lveldere you have been requested to review this Pull request/Issue and eventually sign? Thanks

[andrius-k]

+1

[santocch]

+1

[Dr15Jones]

+1

[fabiocos]

+1

I plan to merge this for next IB

[zhenhu]

+1

[civanch]

+1

[fabiocos]

@Dr15Jones concerning the remark you did last week: in case you have commit comments that ends into the PR description, they will come before the template text. So it will be up to the submitter to properly move them into the description section replacing the text in brackets < > , if (s)he wants to keep the template formatting.

[fabiocos]

merge

[jfernan2]

+1