Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added pull_request_template.md #25848

Merged
merged 6 commits into from Mar 6, 2019
Merged

added pull_request_template.md #25848

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8642af
added pull_request_template.md
smuzaffar Feb 4, 2019
61a6834
Update pull_request_template.md
fabiocos Feb 25, 2019
1be160f
Update pull_request_template.md
fabiocos Feb 25, 2019
ba91492
Update pull_request_template.md
fabiocos Feb 25, 2019
f1ffa87
Update pull_request_template.md
fabiocos Mar 1, 2019
d93008a
Update pull_request_template.md
fabiocos Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions pull_request_template.md
View file
Open in desktop
@@ -0,0 +1,14 @@
#### PR description:

<!-- Please replace this text with a description of the feature proposed or problem addressed, what changes are expected in the output if any, what other PRs or externals it depends upon if any -->

#### PR validation:

<!-- Please replace this text with a description of which tests have been performed to verify the correctness of the PR, including the eventual addition of new code for testing like unit tests, test configurations, additions or updates to the runTheMatrix test workflows -->

#### if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:
- verify that the PR is really indended for the chosen branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: indended -> intended

- verify that changes follow [CMS Naming, Coding, And Style Rules](http://cms-sw.github.io/cms_coding_rules.html)
- verify that the PR passes the basic test procedure suggested in the [CMSSW PR instructions](https://cms-sw.github.io/PRWorkflow.html)