Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch hierarchyconstraints to CMSSW_6_2_X_SHLC #2592

Merged

Conversation

frmeier
Copy link
Contributor

@frmeier frmeier commented Feb 21, 2014

This is a backport to 70X of pull request #2370. Notes from there:

This patch has been prepared by Gero Flucke some time ago, see https://twiki.cern.ch/twiki/bin/viewauth/CMS/TkAlignmentLegacyThoughts, first topic. Testing happened on CMSSW_4_4_5. Results were presented in the alignment meeting of Oct 31, 2013, where the modifications got blessed. See https://twiki.cern.ch/twiki/bin/viewauth/CMS/TkAlPullReq201401 for more details and link to the presentation.
This is an outstanding issue since months that was not put into git.

For consistency, this needs to be put into earlier releases as well.

@frmeier frmeier restored the patch_hierachyconstraints62XSLHC branch February 21, 2014 22:31
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @frmeier (Frank Meier) for CMSSW_6_2_X_SLHC.

Patch hierarchyconstraints to CMSSW_6_2_X_SHLC

It involves the following packages:

Alignment/CommonAlignmentParametrization

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

Tested #2592, #2608 and #2609 together. Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800 and 12000 pass all steps. Tests 12200, 12400, 12600, 12800 and 13000 pass step 1 (fail in step 2 from known errors).

cmsbuild added a commit that referenced this pull request Feb 25, 2014
Patch hierarchyconstraints to CMSSW_6_2_X_SHLC
@cmsbuild cmsbuild merged commit 0e5e319 into cms-sw:CMSSW_6_2_X_SLHC Feb 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants