Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phases for elliptical, sagitta, and skew #2608

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Feb 24, 2014

This extends the systematic misalignment tools. It allows the selection of the direction for certain deformations.

I was asked by the conveners to create this pull request to generalize the systematic misalignment tools.

See slides here: https://indico.cern.ch/event/243962/session/1/contribution/6/material/slides/2.pdf

This is a backport of pull request #2389 in 71X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes for CMSSW_6_2_X_SLHC.

Phases for elliptical, sagitta, and skew

It involves the following packages:

Alignment/TrackerAlignment

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

Tested #2592, #2608 and #2609 together. Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800 and 12000 pass all steps. Tests 12200, 12400, 12600, 12800 and 13000 pass step 1 (fail in step 2 from known errors).

cmsbuild added a commit that referenced this pull request Feb 25, 2014
…-62X-SLHC

Phases for elliptical, sagitta, and skew
@cmsbuild cmsbuild merged commit 7695647 into cms-sw:CMSSW_6_2_X_SLHC Feb 25, 2014
@hroskes hroskes deleted the systematic-misalignments-angles-62X-SLHC branch November 3, 2014 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants