New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Create a prefire veto bit using trigger rules" #26003
Revert "Create a prefire veto bit using trigger rules" #26003
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26003/8522
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/StandardSequences @cmsbuild, @rekovic, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 4024430 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests RelVals
I found errors in the following unit tests:
The relvals timed out after 4 hours. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 4024430 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests RelVals
I found errors in the following unit tests:
The relvals timed out after 4 hours. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
@smuzaffar the RelVal failure looks due to the timeout issue, but I do not see unit tests failure, so I am not sure why the bot is reporting them... |
+operations the circular dependency was unfortunately missed during the original approval |
+1 the reported failure look unrelated to this PR, a standalone tests shows that the unit test failures in the IB are solved with this PR |
merge |
Reverts #25973
A schedule circular dependency with rawDataCollector needs to be solved.