Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Create a prefire veto bit using trigger rules" #26003

Merged

Conversation

fabiocos
Copy link
Contributor

Reverts #25973

A schedule circular dependency with rawDataCollector needs to be solved.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26003/8522

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/StandardSequences
L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 23, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33241/console Started: 2019/02/23 18:24

@cmsbuild
Copy link
Contributor

-1

Tested at: 4024430

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26003/33241/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

  • Unit Tests:

I found errors in the following unit tests:

  • RelVals:

The relvals timed out after 4 hours.
When I ran the RelVals I found an error in the following workflows:
250202.181
N/A


      

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33254/console Started: 2019/02/24 22:22

@cmsbuild
Copy link
Contributor

-1

Tested at: 4024430

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26003/33254/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

  • Unit Tests:

I found errors in the following unit tests:

  • RelVals:

The relvals timed out after 4 hours.

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor Author

@smuzaffar the RelVal failure looks due to the timeout issue, but I do not see unit tests failure, so I am not sure why the bot is reporting them...

@fabiocos
Copy link
Contributor Author

+operations

the circular dependency was unfortunately missed during the original approval

@fabiocos
Copy link
Contributor Author

+1

the reported failure look unrelated to this PR, a standalone tests shows that the unit test failures in the IB are solved with this PR

@fabiocos
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit d6cd14f into master Feb 25, 2019
@smuzaffar smuzaffar deleted the revert-25973-apana-TriggerRulePrefireVetoBit-CMSSW_10_5_X branch May 3, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants