Cleanups in TrackingTools/GsfTools #26020

Dr15Jones · 2019-02-26T16:13:27Z

fixed header inconsistency
removed unneeded dependency on boost

MultiGaussianStateCombiner.h could not be included by itself since it included MultiGaussianState.h which, intern included MultiGaussianState.icc which again included Combiner.h. This change makes sure MultiGaussianState.icc is only included after both MultiGaussianState.h and MultiGaussianStateCombiner.h bodies have been fully parsed.

cmsbuild · 2019-02-26T16:13:56Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-02-26T16:20:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26020/8540

This PR adds an extra 16KB to repository

cmsbuild · 2019-02-26T16:20:38Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

TrackingTools/GsfTools

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2019-02-26T16:20:47Z

please test

cmsbuild · 2019-02-26T16:21:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33301/console Started: 2019/02/26 17:21

Dr15Jones · 2019-02-26T16:21:50Z

To test this, I created temporary .cc files in src/ which only included one header.

cmsbuild · 2019-02-26T20:12:49Z

-1

Tested at: 7927215

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c287dc9
9ae739a
fe753c4
c6d3ed5
f9e6f12
d3568c2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26020/33301/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26020/33301/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26020/33301/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestPhysicsToolsNanoAOD had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c287dc9
9ae739a
fe753c4
c6d3ed5
f9e6f12
d3568c2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26020/33301/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26020/33301/git-merge-result

cmsbuild · 2019-02-26T20:12:54Z

Comparison job queued.

cmsbuild · 2019-02-26T21:45:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26020/33301/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3098286
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3098088
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

Dr15Jones · 2019-02-27T02:14:51Z

please test

cmsbuild · 2019-02-28T14:31:59Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-02-28T14:39:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26020/8565

This PR adds an extra 20KB to repository

cmsbuild · 2019-02-28T14:40:02Z

Pull request #26020 was updated. @cmsbuild, @perrotta, @slava77 can you please check and sign again.

Dr15Jones · 2019-02-28T14:45:31Z

please test

cmsbuild · 2019-02-28T14:45:59Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33340/console Started: 2019/02/28 15:48

cmsbuild · 2019-02-28T17:32:32Z

+1
Tested at: 5d9d90e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26020/33340/summary.html

cmsbuild · 2019-02-28T17:32:52Z

Comparison job queued.

cmsbuild · 2019-02-28T19:17:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26020/33340/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3114826
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3114628
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

slava77 · 2019-03-04T14:42:25Z

+1

for #26020 5d9d90e

code changes are technical, in line with the PR description and the follow up review
jenkins tests pass and comparisons with the baseline show no differences

cmsbuild · 2019-03-04T14:42:53Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-03-04T17:27:39Z

+1

Dr15Jones added 2 commits February 26, 2019 10:04

Removed unnecessary dependency on boost

7927215

cmsbuild added this to the CMSSW_10_6_X milestone Feb 26, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Feb 26, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 26, 2019

cmsbuild added tests-started and removed tests-pending labels Feb 26, 2019

cmsbuild added tests-rejected and removed tests-started labels Feb 26, 2019

cmsbuild added comparison-available and removed comparison-pending labels Feb 26, 2019

cmsbuild added comparison-pending and removed comparison-available tests-rejected labels Feb 27, 2019

cmsbuild added the tests-pending label Feb 28, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 28, 2019

cmsbuild added tests-started and removed tests-pending labels Feb 28, 2019

cmsbuild added tests-approved and removed tests-started labels Feb 28, 2019

cmsbuild added comparison-available and removed comparison-pending labels Feb 28, 2019

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Mar 4, 2019

cmsbuild added orp-approved and removed orp-pending labels Mar 4, 2019

cmsbuild merged commit a737404 into cms-sw:master Mar 4, 2019

slava77 mentioned this pull request Mar 15, 2019

Fixed lost definition of dictionaries errors #26116

Merged

Dr15Jones deleted the headersTrackingToolsGsfTools branch March 15, 2019 16:02

perrotta mentioned this pull request May 13, 2019

Circular inclusion in TrackingTools/GsfTools #23633

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanups in TrackingTools/GsfTools #26020

Cleanups in TrackingTools/GsfTools #26020

Dr15Jones commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

Dr15Jones commented Feb 26, 2019

cmsbuild commented Feb 26, 2019 •

edited

Dr15Jones commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

Dr15Jones commented Feb 27, 2019

cmsbuild commented Feb 28, 2019

cmsbuild commented Feb 28, 2019

cmsbuild commented Feb 28, 2019

Dr15Jones commented Feb 28, 2019

cmsbuild commented Feb 28, 2019 •

edited

cmsbuild commented Feb 28, 2019

cmsbuild commented Feb 28, 2019

cmsbuild commented Feb 28, 2019

slava77 commented Mar 4, 2019

cmsbuild commented Mar 4, 2019

fabiocos commented Mar 4, 2019

Cleanups in TrackingTools/GsfTools #26020

Cleanups in TrackingTools/GsfTools #26020

Conversation

Dr15Jones commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

Dr15Jones commented Feb 26, 2019

cmsbuild commented Feb 26, 2019 • edited

Dr15Jones commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

cmsbuild commented Feb 26, 2019

Dr15Jones commented Feb 27, 2019

cmsbuild commented Feb 28, 2019

cmsbuild commented Feb 28, 2019

cmsbuild commented Feb 28, 2019

Dr15Jones commented Feb 28, 2019

cmsbuild commented Feb 28, 2019 • edited

cmsbuild commented Feb 28, 2019

cmsbuild commented Feb 28, 2019

cmsbuild commented Feb 28, 2019

slava77 commented Mar 4, 2019

cmsbuild commented Mar 4, 2019

fabiocos commented Mar 4, 2019

cmsbuild commented Feb 26, 2019 •

edited

cmsbuild commented Feb 28, 2019 •

edited