Add alias for PixelFEDChannelCollection.

[tsusa]

This PR is the follow up of the PRs: #25466 and #25748 that introduced the simulation of the StuckTBMs. In the current implementation the code does not work properly, due to the fact that the same "InputLabel" is used in DigiToRaw for two collections [DetSetVector and PixelFEDChannelCollection]. In EventFilter/SiPixelRawToDigi/python/SiPixelDigiToRaw_cfi.py "InputLabel" is set to "simSiPixelDigis" and there is no PixelFEDChannelCollection with that label, instead PixelFEDChannelCollection has the label "mix" or "mixData". In order to fix the problem, the same label "simSiPixelDigis" is also set for PixelFEDChannelCollection in digitizer
.

[cmsbuild]

The code-checks are being triggered in jenkins.

[tsusa]

@mmusich @tvami @leac @veszpv

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26042/8585

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @tsusa (Tatjana Susa) for master.

It involves the following packages:

SimGeneral/MixingModule
SimTracker/SiPixelDigitizer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[tsusa]

type bug-fix

[leac]

@mmusich @tvami @leac @veszpv

Why was I mentioned? :)

[tvami]

@mmusich @tvami @leac @veszpv

Why was I mentioned? :)

It was meant for her: https://gitlab.cern.ch/leac

[mmusich]

@leaca correct gitHub tag

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33378/console Started: 2019/03/04 09:43

[cmsbuild]

+1
Tested at: 2ca23a4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26042/33378/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26042/33378/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114826
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114628
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[mmusich]

@makortel @civanch
can you please check again if this is now fine ? It would be very important for us to try to get this included in 10.6.0_pre1

[makortel]

@cmsbuild, please test workflow 25402.18,250402.181

[makortel]

Looks ok to me, but let's test the fastsim pileup workflows just to be sure.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33436/console Started: 2019/03/06 16:39

[cmsbuild]

+1
Tested at: d7c4abf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26042/33436/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26042/33436/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114826
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114628
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

The extra tests seem to have been ignored by cms-bot, I will restart them as soon as the reference IB is ok

[tsusa]

We run the tests:
runTheMatrix.py -l 25402.18,250402.181
Here is the result:
20:47 2019-date Thu Mar 7 13:12:10 2019; exit: 0 0 0
2 2 2 tests passed, 0 0 0 failed

[fabiocos]

@tsusa @makortel I can confirm I got the same in my standalone test

[civanch]

unhold

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1