-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulation of the pixel bad components on the FED channel basis #25466
Simulation of the pixel bad components on the FED channel basis #25466
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25466/7557 |
A new Pull Request was created by @tsusa (Tatjana Susa) for master. It involves the following packages: CondCore/CondDB @andrius-k, @schneiml, @ianna, @kpedro88, @nsmith-, @rekovic, @thomreis, @pohsun, @perrotta, @civanch, @zhenhu, @cmsbuild, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @tocheng, @slava77, @ggovi, @fabiocos, @prebello, @kmaeshima, @pgunnell, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
something wrong happened with the commits. |
… CondFormats in view of using them in stuckTBM simulation
…nst missing scenarios in maps
4ee9a0d
to
1508af4
Compare
[a]
|
#25509 should fix the lost dictionary issue. |
Thank you @smuzaffar |
+1
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The PR introduces a simulation of the pixel bad components on the FED channel bases (needed for the simulation of stuckTBMs and DCDC issue). To simulated FED bad channel the scenarios from Pixel PCL payloads are utilised. The approach was presented at the last simulation meeting https://indico.cern.ch/event/777956/contributions/3239525/attachments/1765581/2866399/tanjaSim_04112018.pdf.
The PR introduces the novel
SiPixelFEDChannelContainer
andSiPixelQualityProbabilities
Condition formats.The changes proposed here are:
SiPixelFEDChannelContainer
andSiPixelQualityProbabilities
;EventSetup
, respectivelySiPixelStatusScenariosRcd
andSiPixelStatusScenarioProbabilityRcd
;CondFormats
;Caveat:
SiPixelFEDChannelContainer
is essentially a wrapper aroundPixelFEDChannel
, which being aDataFormat
necessitates its own (trivial) serialization/deserialization rules (implemented inCondFormats/External
). As we don't foresee to ever have to change the content of theDataFormat
schema evolution is implicitly avoided.The changes are introduced in the SiPixelDigitizer, where in each event one scenario is randomly chosen and the bad components contained in the chosen scenario are killed. The information about killed components is propagated to the the tracking via SiPixelRawToDigi.
The new feature is switched off by default.
@mmusich @veszpv