New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config in Merge.py #26110
Fix config in Merge.py #26110
Conversation
A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_9_4_X. It involves the following packages: Configuration/DataProcessing @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@srimanob this needs a fix also in master. Furthermore while testing it I see an unrelated problem in RunMerge.py, I will provide a PR |
@fabiocos Ah, thx. I see you put it together with other fix. |
Pull request #26110 was updated. @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again. |
code-checks |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26110/8691
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready The workflows 1001.0, 1000.0, 140.53, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Comparison Summary:
|
backport #26120 |
+operations consistent with the master version (thanks @srimanob for the initial fix) |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Another fix on Merge.py to bypass the version check on production side.
Fix also RunMerge.py that self.mergeNANO is missing.
Validated by using
python RunMerge.py --input-files=a.root
output file seems to be OK. bypassVersionCheck appears correctly.
`import FWCore.ParameterSet.Config as cms
process = cms.Process("Merge")
process.source = cms.Source("PoolSource",
bypassVersionCheck = cms.untracked.bool(True),
fileNames = cms.untracked.vstring("['a.root']")
)
process.Merged = cms.OutputModule("PoolOutputModule",
fileName = cms.untracked.string('Merged.root')
)
process.outputPath = cms.EndPath(process.Merged)`