Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config in Merge.py #26110

Merged
merged 2 commits into from Mar 9, 2019
Merged

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Mar 8, 2019

Another fix on Merge.py to bypass the version check on production side.
Fix also RunMerge.py that self.mergeNANO is missing.

Validated by using
python RunMerge.py --input-files=a.root

output file seems to be OK. bypassVersionCheck appears correctly.

`import FWCore.ParameterSet.Config as cms

process = cms.Process("Merge")

process.source = cms.Source("PoolSource",
bypassVersionCheck = cms.untracked.bool(True),
fileNames = cms.untracked.vstring("['a.root']")
)
process.Merged = cms.OutputModule("PoolOutputModule",
fileName = cms.untracked.string('Merged.root')
)

process.outputPath = cms.EndPath(process.Merged)`

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_9_4_X.

It involves the following packages:

Configuration/DataProcessing

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Mar 8, 2019

@srimanob this needs a fix also in master. Furthermore while testing it I see an unrelated problem in RunMerge.py, I will provide a PR

@srimanob
Copy link
Contributor Author

srimanob commented Mar 8, 2019

@fabiocos Ah, thx. I see you put it together with other fix.

@fabiocos
Copy link
Contributor

fabiocos commented Mar 8, 2019

@srimanob better to adapt this to #26120 (i.e. add the fix to RunMerge.py)
This should enter quickly into a patch, as Merge.py as it is now looks broken

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

Pull request #26110 was updated. @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again.

@srimanob
Copy link
Contributor Author

srimanob commented Mar 8, 2019

@fabiocos OK, I add the fix for RunMerge.py following #26120

@fabiocos
Copy link
Contributor

fabiocos commented Mar 8, 2019

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26110/8691

  • This PR adds an extra 12KB to repository

@fabiocos
Copy link
Contributor

fabiocos commented Mar 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33492/console Started: 2019/03/08 22:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26110/33492/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 103
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721228
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@fabiocos
Copy link
Contributor

fabiocos commented Mar 9, 2019

backport #26120

@fabiocos
Copy link
Contributor

fabiocos commented Mar 9, 2019

+operations

consistent with the master version (thanks @srimanob for the initial fix)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 9, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants