Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types in Merge.py, and RunMerge.py for missing mergeNANO default #26120

Merged
merged 1 commit into from Mar 8, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Mar 8, 2019

PR description:

This PR proposes two independent fixes to Configuration/DataProcessing:

PR validation:

python RunMerge.py --input-files=a.root 

now runs smoothly and produces the desired RunMergeCfg.py output with the bypassVersionCheck option activated by default:

process.source = cms.Source("PoolSource",
    bypassVersionCheck = cms.untracked.bool(True),
    fileNames = cms.untracked.vstring("[\'a.root\']")
)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

The code-checks are being triggered in jenkins.

@srimanob srimanob mentioned this pull request Mar 8, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26120/8687

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/DataProcessing

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos fabiocos mentioned this pull request Mar 8, 2019
@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 8, 2019

please test

not testing really anything here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33489/console Started: 2019/03/08 18:39

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 8, 2019

+operations

the test configuration has been verified to build correctly as desired in a standalone check (see description)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 8, 2019

+1

@fabiocos
Copy link
Contributor Author

fabiocos commented Mar 8, 2019

merge

@cmsbuild cmsbuild merged commit 6d3e804 into cms-sw:master Mar 8, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26120/33489/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114829
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114631
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants