New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix types in Merge.py, and RunMerge.py for missing mergeNANO default #26120
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26120/8687
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/DataProcessing @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test not testing really anything here |
The tests are being triggered in jenkins. |
+operations the test configuration has been verified to build correctly as desired in a standalone check (see description) |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
PR description:
This PR proposes two independent fixes to Configuration/DataProcessing:
the recent update of Merge.py from Add options to bypassVersionCheck in Merge step #26030 introduces a bug, as bypassVersionCheck should be defined from CfgTypes and not cms (see Fix config in Merge.py #26110 by @srimanob);
while testing it I have realized RunMerge.py fails to build due to the lack of a mergeNano default, now added.
PR validation:
now runs smoothly and produces the desired RunMergeCfg.py output with the bypassVersionCheck option activated by default: