Pf gen jet specifics #26125

rappoccio · 2019-03-08T18:48:28Z

PR description:

This PR adds PF-like particle fractions to GenJet, at long last. The long shutdown is a good opportunity. It adds 5 floats and 5 ints to GenJet.

Addresses this issue

PR validation:

This is gen-only so I used WF 5.1.

Example of changes:

jet   4: pt  41.1, eta +1.13, energies: ch  32.69 nh   9.38 ce   0.00 ne  28.45 mu   0.00, mults: ch   7 nh   2 ce   0 ne  11 mu   0
jet   5: pt  37.4, eta +1.45, energies: ch  43.99 nh  34.36 ce   0.00 ne   6.96 mu   0.00, mults: ch  10 nh   6 ce   0 ne   2 mu   0
jet   6: pt  12.0, eta +2.78, energies: ch  93.68 nh   0.00 ce   0.00 ne   3.35 mu   0.00, mults: ch   4 nh   0 ce   0 ne   2 mu   0
jet   7: pt   9.2, eta +2.42, energies: ch  46.10 nh   6.16 ce   0.00 ne   0.00 mu  43.57, mults: ch   2 nh   1 ce   0 ne   0 mu   1

if this PR is a backport please specify the original PR:

This is not a backport.

cmsbuild · 2019-03-08T18:48:59Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-03-08T18:54:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26125/8690

This PR adds an extra 24KB to repository

cmsbuild · 2019-03-08T18:55:11Z

A new Pull Request was created by @rappoccio for master.

It involves the following packages:

Configuration/PyReleaseValidation
DataFormats/HepMCCandidate
DataFormats/JetReco
RecoJets/JetProducers

@perrotta, @pgunnell, @prebello, @zhenhu, @perrozzi, @efeyazgan, @kpedro88, @cmsbuild, @slava77, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@jdamgov, @TaiSakuma, @jdolen, @yslai, @schoef, @rovere, @Martin-Grunewald, @makortel, @nhanvtran, @gkasieczka, @clelange, @ahinzmann, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2019-03-08T19:29:45Z

wrong base in the PR branch (10_5_X vs. 10_6_X). Can you rebase it to a 10_6 IB? (10_6_0_pre1 should come out soon...)

kpedro88 · 2019-03-08T19:38:27Z

DataFormats/JetReco/interface/GenJet.h

+  float muonEnergy         () const { return m_specific.mMuonEnergy         ;}
+  int chargedHadronMultiplicity() const { return m_specific.mChargedHadronMultiplicity;}
+  int neutralHadronMultiplicity() const { return m_specific.mNeutralHadronMultiplicity;}
+  int chargedEmMultiplicity    () const { return m_specific.mChargedEmMultiplicity    ;}


in addition to charged EM and neutral EM, the PFJets provide electron and photon (which are basically the same, I think). Maybe these could be added here for consistency?

I was of two minds about this, but it's probably more confusing than it's worth. "Charged" and "Neutral" EM are the same as "electron" and "photon" in the central region but differ in the forward region. For sure we shouldn't add separate data members, the information would be redundant. I could add accessors that are identical, but that seemed more confusing to me.

I can do the rebase though.

cmsbuild · 2019-03-08T20:18:03Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-03-08T20:23:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26125/8692

This PR adds an extra 20KB to repository

cmsbuild · 2019-03-08T20:23:37Z

Pull request #26125 was updated. @perrotta, @efeyazgan, @perrozzi, @cmsbuild, @slava77, @alberto-sanchez, @qliphy can you please check and sign again.

cmsbuild · 2019-03-22T17:59:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26125/8875

This PR adds an extra 24KB to repository

cmsbuild · 2019-03-22T17:59:45Z

Pull request #26125 was updated. @perrotta, @efeyazgan, @perrozzi, @cmsbuild, @slava77, @alberto-sanchez, @qliphy can you please check and sign again.

perrotta · 2019-03-22T19:50:48Z

please test

cmsbuild · 2019-03-22T19:53:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33728/console Started: 2019/03/22 20:53

cmsbuild · 2019-03-23T00:50:54Z

+1
Tested at: cfbdc8b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26125/33728/summary.html

cmsbuild · 2019-03-23T00:50:58Z

Comparison job queued.

cmsbuild · 2019-03-23T02:51:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26125/33728/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3114829
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3114631
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

perrotta · 2019-03-26T13:38:50Z

This PR adds 5 floats and 5 into GenJet.

The increase in miniAOD size have been measured with the PU TTbar workflow 11024:

Compare packed values
-----------------------------------------------------------------
   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
    160.3 ->       161.6          1      0.8   0.00     recoGenJets_slimmedGenJetsAK8SoftDropSubJets__RECO.
    320.7 ->       324.7          4      1.3   0.00     recoGenJets_slimmedGenJetsAK8__RECO.
    745.3 ->       889.8        144     17.7   0.18     recoGenJets_slimmedGenJets__RECO.
-------------------------------------------------------------
    81195 ->       81345        150             0.2     ALL BRANCHES

150 B additional per event to slimmedGenJets in TTbar PU MC can be considered as acceptable, in my opinion

perrotta · 2019-03-26T13:40:33Z

+1

PF-like particle fractions are added to GenJet's
The miniAOD size increase in the TTBar PU wf 11024 is approximately 150 B/evt
Jenkins test pass and show no differences for all other quantities

alberto-sanchez · 2019-03-26T23:10:23Z

+1

cmsbuild · 2019-03-26T23:10:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-03-27T21:17:03Z

+1

cmsbuild added this to the CMSSW_10_6_X milestone Mar 8, 2019

cmsbuild added code-checks-pending comparison-pending generators-pending orp-pending pdmv-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Mar 8, 2019

rappoccio mentioned this pull request Mar 8, 2019

Adding PF-like GenJet specifics #26126

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 8, 2019

kpedro88 reviewed Mar 8, 2019

View reviewed changes

Adding PF-like GenJet specifics

f50af7e

rappoccio force-pushed the pfGenJetSpecifics branch from 4991d54 to f50af7e Compare March 8, 2019 20:16

cmsbuild added code-checks-pending and removed code-checks-approved pdmv-pending upgrade-pending labels Mar 8, 2019

rappoccio mentioned this pull request Mar 8, 2019

Pf gen jet specifics backport to 105x #26127

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 8, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 22, 2019

cmsbuild added tests-started and removed tests-pending labels Mar 22, 2019

cmsbuild added tests-approved and removed tests-started labels Mar 23, 2019

cmsbuild added comparison-available and removed comparison-pending labels Mar 23, 2019

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 26, 2019

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Mar 26, 2019

cmsbuild added orp-approved and removed orp-pending labels Mar 27, 2019

cmsbuild merged commit 63ed7a2 into cms-sw:master Mar 27, 2019

rappoccio mentioned this pull request Apr 3, 2019

Add PF-like GenJet Specifics #26115

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pf gen jet specifics #26125

Pf gen jet specifics #26125

rappoccio commented Mar 8, 2019 •

edited

cmsbuild commented Mar 8, 2019

cmsbuild commented Mar 8, 2019

cmsbuild commented Mar 8, 2019

kpedro88 commented Mar 8, 2019

kpedro88 Mar 8, 2019

rappoccio Mar 8, 2019

cmsbuild commented Mar 8, 2019

cmsbuild commented Mar 8, 2019

cmsbuild commented Mar 8, 2019

cmsbuild commented Mar 22, 2019

cmsbuild commented Mar 22, 2019

perrotta commented Mar 22, 2019

cmsbuild commented Mar 22, 2019 •

edited

cmsbuild commented Mar 23, 2019

cmsbuild commented Mar 23, 2019

cmsbuild commented Mar 23, 2019

perrotta commented Mar 26, 2019

perrotta commented Mar 26, 2019

alberto-sanchez commented Mar 26, 2019

cmsbuild commented Mar 26, 2019

fabiocos commented Mar 27, 2019

Pf gen jet specifics #26125

Pf gen jet specifics #26125

Conversation

rappoccio commented Mar 8, 2019 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Mar 8, 2019

cmsbuild commented Mar 8, 2019

cmsbuild commented Mar 8, 2019

kpedro88 commented Mar 8, 2019

kpedro88 Mar 8, 2019

Choose a reason for hiding this comment

rappoccio Mar 8, 2019

Choose a reason for hiding this comment

cmsbuild commented Mar 8, 2019

cmsbuild commented Mar 8, 2019

cmsbuild commented Mar 8, 2019

cmsbuild commented Mar 22, 2019

cmsbuild commented Mar 22, 2019

perrotta commented Mar 22, 2019

cmsbuild commented Mar 22, 2019 • edited

cmsbuild commented Mar 23, 2019

cmsbuild commented Mar 23, 2019

cmsbuild commented Mar 23, 2019

perrotta commented Mar 26, 2019

perrotta commented Mar 26, 2019

alberto-sanchez commented Mar 26, 2019

cmsbuild commented Mar 26, 2019

fabiocos commented Mar 27, 2019

rappoccio commented Mar 8, 2019 •

edited

cmsbuild commented Mar 22, 2019 •

edited