Removed unused RecoParticleFlow/PFClusterShapeProducer package

[guitargeek]

PR description:

This PR is in the same spirit as #26184.

This package was not used anywhere else in CMSSW and the plugin it provided was also not used.

Please, if you know what this code was used for of if it's still necessary, I am happy to learn about it!

PR validation:

CMSSW still compiles and local matrix tests pass.

[cmsbuild]

The code-checks are being triggered in jenkins.

[slava77]

@cbernet @pjanot
@hatakeyamak

are there any still possibly planned use cases for RecoParticleFlow/PFClusterShapeProducer?
I checked back to the last times these packages were moved around in CMSSW_3_1_0 and git grep there returns no use cases of the pfClusterShapes.

[hatakeyamak]

I will try to have a closer look, but it will be nice to hear from @cbernet and @pjanot :)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26186/8780

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoParticleFlow/PFClusterShapeProducer
Utilities/ReleaseScripts

@cmsbuild, @smuzaffar, @Dr15Jones, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @cbernet, @wddgit, @lgray, @Martin-Grunewald, @bachtis, @hatakeyamak, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33604/console Started: 2019/03/14 23:37

[cmsbuild]

+1
Tested at: 20dc099
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26186/33604/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26186/33604/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114631
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[Dr15Jones]

+1

[cmsbuild]

Pull request #26186 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @perrotta, @slava77 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33619/console Started: 2019/03/15 21:27

[Dr15Jones]

+1

[cmsbuild]

+1
Tested at: b5c0b54
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26186/33619/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26186/33619/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114631
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[slava77]

The tests passed and there were no objections yet to the removal.
My plan is to leave this open for comments for a few more days and then signoff by the end of the week if there will be no objections.

[hatakeyamak]

I checked:
https://github.com/hatakeyamak/PFCalibration
which is a fork of:
https://github.com/spandeyehep/PFCalibration
and I don't see any reference to PFClusterShapeProducer, so I think it's safe to remove it.

The use of shape information is something I think we should be exploring in future, though, but I believe it can be done without this package.

[slava77]

+1

for #26186 b5c0b54

• code changes are in line with the PR description and the follow up review
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1