Make L1Trigger/ME0Trigger comply with new CMSSW style rules.

[dildick]

PR description:

Make L1Trigger/ME0Trigger comply with new CMSSW style rules. There should be no change in performance.

PR validation:

Code compiles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26203/8806

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/ME0Trigger

@cmsbuild, @rekovic, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33637/console Started: 2019/03/18 08:29

[cmsbuild]

-1

Tested at: 300f9a1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26203/33637/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

Entering library rule at src/L1Trigger/ME0Trigger/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-17-2300/src/L1Trigger/ME0Trigger/plugins/ME0TriggerProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-17-2300/src/L1Trigger/ME0Trigger/plugins/ME0TriggerPseudoProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-17-2300/src/L1Trigger/ME0Trigger/plugins/SealModule.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-17-2300/src/L1Trigger/ME0Trigger/plugins/ME0TriggerProducer.cc:2:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-17-2300/poison/L1Trigger/ME0Trigger/src/ME0TriggerBuilder.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-17-2300/src/L1Trigger/ME0Trigger/plugins/ME0TriggerPseudoProducer.cc:2:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-03-17-2300/poison/L1Trigger/ME0Trigger/src/ME0TriggerPseudoBuilder.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33641/console Started: 2019/03/18 16:13

[dildick]

@kpedro88 Thanks. I must have forgotten to change two instances of src/ to interface/

[cmsbuild]

+1
Tested at: af351d1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26203/33641/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26203/33641/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114631
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

+upgrade

[fabiocos]

@rekovic this looks a simple technical refresh, could you please check?

[dildick]

@fabiocos It is. This PR merely moves all header files to the interface/ directory for the ME0Trigger subpackage.

[fabiocos]

+1

@rekovic please sign it for future reference, or comment for possible updates, it looks straightforward

[fabiocos]

merge

[rekovic]

+1
Migration of the package.

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.