Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked pixel pair MVA selection for pp_on_AA #26217

Merged
merged 1 commit into from Mar 20, 2019

Conversation

abaty
Copy link
Contributor

@abaty abaty commented Mar 19, 2019

PR description:

This PR tweaks the MVA selection for the pixel pair recovery step in heavy ion collisions. This step was seen to cause a large fake rate that was problematic for jet reconstruction in central events. The required MVA value is simply required to be slightly higher to curtail the amount of fake tracks. This change is needed for a reRECO of the jet-triggered data.

PR validation:

More information on the effects of this change can be found in the presentation that was shown at the XEB meeting today:

https://www.dropbox.com/s/j4ej3pc7tdroy4p/HI-PAG_FakeJets_20190318.pptx?dl=0#

@icali @mandrenguyen @echapon

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26217/8835

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abaty for master.

It involves the following packages:

RecoTracker/IterativeTracking

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33674/console Started: 2019/03/19 17:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26217/33674/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 510 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114829
  • DQMHistoTests: Total failures: 1028
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3113604
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Mar 20, 2019

More information on the effects of this change can be found in the presentation that was shown at the XEB meeting today:

is there a more permanent link (indico or similar)?

@slava77
Copy link
Contributor

slava77 commented Mar 20, 2019

in jenkins wf 140.56 (2018 data)
all_OldVSNew_RunHI2018wf140p56c_recoPFCandidates_particleFlow__reRECO_obj_eta10
all_OldVSNew_RunHI2018wf140p56c_recoPFCandidates_particleFlow__reRECO_obj_phi11

this looks consistent with p6 in the slides provided with this PR description.

Also, as expected, the generalTracks are affected only in the quality variable (no other changes in generalTracks)
all_OldVSNew_RunHI2018wf140p56c_recoTracks_generalTracks__reRECO_obj_qualityMask

@slava77
Copy link
Contributor

slava77 commented Mar 20, 2019

+1

for #26217 2a82046

  • changes are as described in the slides
  • jenkins tests pass and comparisons with the baseline show differences only in the HI workflows with pp_on_AA reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@abaty
Copy link
Contributor Author

abaty commented Mar 20, 2019

is there a more permanent link (indico or similar)?

I also put the file here on a twiki page:
https://twiki.cern.ch/twiki/pub/CMS/HITracking2018PbPb/HI-PAG_FakeJets_20190318.pptx

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dd182fc into cms-sw:master Mar 20, 2019
cmsbuild added a commit that referenced this pull request Mar 28, 2019
Tweaked pixel pair MVA selection for pp_on_AA (backport of #26217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants