Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythia filter to focus on the probe side of B decays #26286

Merged
merged 1 commit into from Apr 4, 2019

Conversation

gkaratha
Copy link
Contributor

PR description:

Currently in CMSSW we do not have any Filter to look at the probe side of an event if the decay itself has a identical particle. eg. In B parking we want to generate B->mumuK in which the mu should not have to pass any filter (probe B). Additionally, we want the filter to be passed by another muon in the event (B+->mu1mu2K, B- -> mu3X, we want to filter mu3 and only mu3).

PR validation:

The code has been validated in mumuK(), J/psi(->mumu)K() with direct comparison to the analysis code. The gain using the existing filters and this new filter, has also been studied
mu3_validation
gainInUsableMC

if this PR is a backport please specify the original PR:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 28, 2019

A new Pull Request was created by @gkaratha for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/GenFilters

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@gkaratha
Copy link
Contributor Author

Perhaps @jordanm wants to follow this

@alberto-sanchez
Copy link
Member

@gkaratha, @jordanm make sure to make the appropriate PR to master as well.

@alberto-sanchez
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 28, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33834/console Started: 2019/03/28 18:25

@gkaratha
Copy link
Contributor Author

Dear Alberto,

Yes I am going to try again tonight for 10_6_X. I tried several times already, from different machines but I constantly get "ERROR: Unable to find release area for "CMSSW" version "CMSSW_10_6_X_2019-03-27-2300" for arch slc6_amd64_gcc700". I tried for different days and times with the same result. But when I changed from CMSSW_10_6_X_2019-03-27-2300 -> CMSSW_10_2_X_2019-03-27-2300 , it worked fine! This is why the "backport" came first. Also because I think that this release will be used for MC production. I will try later to properly propagated to 10_6_X as well. Thanks.

Best regards,
George Karathanasis

@alberto-sanchez
Copy link
Member

You should use a slc7 (or equivalente machine). Perhaps lxplus7.
Any new features/fix has to go to master, no matter if the production is a different release. Once integrate there, the backport can be made.

@gkaratha
Copy link
Contributor Author

Dear Alberto,

Ok thanks! I will try on lxplus7 then.

Best regards,
George

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26286/33834/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007206
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@gkaratha
Copy link
Contributor Author

Dear @alberto-sanchez ,

I have made the backport in 10_6_X using the slc7 as you proposed. That was the problem after all. The PR is here: #26300 .Thanks.

Best,
George

@alberto-sanchez
Copy link
Member

backport of #26300

@alberto-sanchez
Copy link
Member

+1

@fabiocos, We will need this in production at the earliest, once integrated in master. Thanks!

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2019

+1

@cmsbuild cmsbuild merged commit 3a33ffc into cms-sw:CMSSW_10_2_X Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants