PPS geometry fix for Timing detectors

[fabferro]

PR description:

Fix in the numbering of PPS UFSD and double diamond detector channels for 2017 and 2018

PR validation:

The changes have been validated re-processing 2017 and 2018 data using CMSSW_10_6_0_pre2 release

[fabferro]

FYI @forthommel @ianna

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26316/9019

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

Geometry/VeryForwardData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@forthommel, @jan-kaspar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33922/console Started: 2019/04/03 11:10

[cmsbuild]

+1
Tested at: 4157aa6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26316/33922/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26316/33922/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3139747
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3139549
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[ianna]

@fabiocos - FYI, this update needs to be put in the GT to be used for the UL re-reco

[fabiocos]

+1

@ianna @fabferro I assume there will be a corresponding DB payload to be updated, am I correct?

[fabferro]

+1

@ianna @fabferro I assume there will be a corresponding DB payload to be updated, am I correct?

Yes, that's the idea. Working on it.

[fabiocos]

@fabferro @ianna well the sooner the better, otherwise we have an inconsistency between ideal description in the release the the actual payload in the DB, right?

[fabferro]

@fabferro @ianna well the sooner the better, otherwise we have an inconsistency between ideal description in the release the the actual payload in the DB, right?

Yes, in fact it's definitely something we want to avoid. The db payload is not yet ready because I found some difficulties in producing/testing it. The discussion with @ianna and @cvuosalo is ongoing. I hope we can solve the issue in short time.