[PPS] Timing calibration for diamond rechits/tracks

[forthommel]

PR description:

This PR modifies the rechits producer for PPS diamond detectors to insert the calibrated hit time of arrival, and propagates this information onto a general track time, following the same recipe as introduced #25465 for TOTEM vertical timing detectors.
As most of the algorithmic part is common, the overall track-from-hits timing extraction method is moved to the base class.
The calibration objects are also shared between the two reconstruction codes, introduced in #25777 (with ESSource modified in #26207 for diamond calibration files parsing).
This track timing information is propagated (with no code change) up to the CTPPSLocalTrackLite miniAOD-optimised object.

PR validation:

runTheMatrix.py -l limited test ongoing.

Warning as no GT is currently holding the diamond timing calibration for all periods defined in 2017-18, it its current state, this PR should return an uncorrected (thus unmodified) rechits collection.

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26327/9224

• This PR adds an extra 84KB to repository

[cmsbuild]

Pull request #26327 was updated. @perrotta, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @slava77, @pohsun can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34144/console Started: 2019/04/11 11:18

[cmsbuild]

+1
Tested at: 149e399
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26327/34144/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e3f89fb
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26327/34144/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26327/34144/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26327/34144/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3140495
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3140296
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[pohsun]

+1

[slava77]

+1

for #26327 149e399

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show only a difference in ctppsDiamondRecHits time over threshold (ToT) as noted already in [PPS] Timing calibration for diamond rechits/tracks #26327 (comment) as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1