Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPS] Timing calibration for diamond rechits/tracks #26327

Merged
merged 29 commits into from Apr 12, 2019
Merged

[PPS] Timing calibration for diamond rechits/tracks #26327

merged 29 commits into from Apr 12, 2019

Commits on Apr 2, 2019

  1. Passing geometry to rechits producer by reference

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    eb84411 View commit details
    Browse the repository at this point in the history

  2. Only fill output rechits collection if digis are found

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    fdf6016 View commit details
    Browse the repository at this point in the history

  3. Can now feed calibration parameters to the algorithm

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    7fc94da View commit details
    Browse the repository at this point in the history

  4. First matches to the algorithm, calibration retrieval from db in test

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    1237f96 View commit details
    Browse the repository at this point in the history

  5. Implementation of timing calibration corrections

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    7d20854 View commit details
    Browse the repository at this point in the history

  6. Include chain cleanup

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    d8b1bd5 View commit details
    Browse the repository at this point in the history

  7. Fixed sign convention

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    7baa19f View commit details
    Browse the repository at this point in the history

  8. Using emplace_back instead of push_back + copy

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    b1c0f0b View commit details
    Browse the repository at this point in the history

  9. Cleanup; not computing tot corrections if invalid tot

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    dd029d7 View commit details
    Browse the repository at this point in the history

  10. Ensure calibration function is defined before applying its correction

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    35fe3f2 View commit details
    Browse the repository at this point in the history

  11. Adding timing to diamond tracks

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    cfbd761 View commit details
    Browse the repository at this point in the history

  12. Simplification through typedefs

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    7ef3715 View commit details
    Browse the repository at this point in the history

  13. Slight cleanup

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    ac01fdc View commit details
    Browse the repository at this point in the history

  14. Tolerance for tracks<>hits association now a parent algorithm attribute

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    86ecede View commit details
    Browse the repository at this point in the history

  15. Simplification of tests through common enum definition

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    1c67d40 View commit details
    Browse the repository at this point in the history

  16. New helper method to compute time+uncertainty from associated hits co… 

    …llection
    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    9edab17 View commit details
    Browse the repository at this point in the history

  17. Common method to avoid stupid copy/paste

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    9c3e481 View commit details
    Browse the repository at this point in the history

  18. Flag added to exclude single-edged hits

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    d82d5e8 View commit details
    Browse the repository at this point in the history

  19. Also exclude single-edged rechits from track building part

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    2cdcbb4 View commit details
    Browse the repository at this point in the history

  20. Timing calibrations tests moved to CalibPPS package

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    9339855 View commit details
    Browse the repository at this point in the history

  21. const timeEval method

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    9cc8e3e View commit details
    Browse the repository at this point in the history

  22. Also compute the ToT if no calibration function is present

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    63025b4 View commit details
    Browse the repository at this point in the history

  23. Cleanup of local tracks fitters' fillDescriptions methods

    @forthommel
    forthommel committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    31f0154 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. Channel time offset applied at the OOT computation level

    @forthommel
    forthommel committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    f300aef View commit details
    Browse the repository at this point in the history

  2. Better time-walk correction variable naming

    @forthommel
    forthommel committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    80fa1f1 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. Include cmath to track recognition algorithm for header consistency

    @forthommel
    forthommel committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    9e32e5f View commit details
    Browse the repository at this point in the history

  2. Merge pull request #5 from forthommel/ppsDiamTiming_rechitsProd_RHpatch 

    Time offset specified before computing the time slice
    @forthommel
    forthommel committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    e3f89fb View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Using edm::isNotFinite instead of std::isnan

    @forthommel
    forthommel committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    760a3d4 View commit details
    Browse the repository at this point in the history

  2. Corrected include path to isNotFinite definition header

    @forthommel
    forthommel committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    149e399 View commit details
    Browse the repository at this point in the history