Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import additions for UL from CMSSW_9_4_13_UL1 (#26168) and #26211 #26399

Merged
merged 1 commit into from Apr 15, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Apr 9, 2019

PR description:

This PR is meant to import into the main CMSSW_9_4_X branch the additions for UL tested separately in the test build CMSSW_9_4_13_UL1 (based on #26168) and on the further addition #26211 .

PR validation:

This code has been used in tests and running without issues in CMSSW_9_4_MAOD_X IBs for a while.

if this PR is a backport please specify the original PR: #26168 and #26211

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_9_4_X.

It involves the following packages:

Configuration/DataProcessing
DataFormats/CSCDigi
SimDataFormats/GeneratorProducts

@efeyazgan, @perrozzi, @civanch, @mdhildreth, @cmsbuild, @franzoni, @alberto-sanchez, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@dildick, @Martin-Grunewald, @ptcox, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 9, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34072/console Started: 2019/04/09 12:37

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 9, 2019

@franzoni @srimanob FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26399/34072/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 102
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721229
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@civanch
Copy link
Contributor

civanch commented Apr 9, 2019

+1

@alberto-sanchez
Copy link
Member

+1

@fabiocos
Copy link
Contributor Author

+operations

@fabiocos
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit f0ec564 into cms-sw:CMSSW_9_4_X Apr 15, 2019
@fabiocos fabiocos deleted the fc-94Xul1 branch May 31, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants