-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for UL reprocessing test: DataProcessing and CSC missing data format #26168
Conversation
A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_9_4_MAOD_X. It involves the following packages: Configuration/DataProcessing @civanch, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
code-checks |
The code-checks are being triggered in jenkins. |
@srimanob FYI |
@fabiocos , code checks will not work since it is an old release where we don't have Clang Id. |
@gudrutis ok thanks for recalling me... |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+operations |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_MAOD_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 the DQM differences look unrelated to this PR |
PR description:
This PR adds the requested updates to 9_4_MAOD_X (synchronized to 9_4_X) in order to test the workflow chain for the UL reprocessing (after resetting Configuration/DataProcessing to the 9_4_13 status) corresponding to #26045, #26110, #26148 (1sf commit for Configuration/DataProcessing) and #26106 (2nd commit for CSCCLCTPreTriggerDigi backport).
PR validation:
For DataProcessing see the discussion of the original PRs (also in master), for CSCCLCTPreTriggerDigi the code compiles, and the event content in tests look unchanged as expected (a new DataFormat is defined, but there is no code to produce and consume it in the release).
if this PR is a backport please specify the original PR: #26030, #26120, #26147