Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for UL reprocessing test: DataProcessing and CSC missing data format #26168

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

fabiocos
Copy link
Contributor

PR description:

This PR adds the requested updates to 9_4_MAOD_X (synchronized to 9_4_X) in order to test the workflow chain for the UL reprocessing (after resetting Configuration/DataProcessing to the 9_4_13 status) corresponding to #26045, #26110, #26148 (1sf commit for Configuration/DataProcessing) and #26106 (2nd commit for CSCCLCTPreTriggerDigi backport).

PR validation:

For DataProcessing see the discussion of the original PRs (also in master), for CSCCLCTPreTriggerDigi the code compiles, and the event content in tests look unchanged as expected (a new DataFormat is defined, but there is no code to produce and consume it in the release).

if this PR is a backport please specify the original PR: #26030, #26120, #26147

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_9_4_MAOD_X.

It involves the following packages:

Configuration/DataProcessing
DataFormats/CSCDigi

@civanch, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@dildick, @Martin-Grunewald, @ptcox, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

code-checks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fabiocos
Copy link
Contributor Author

@srimanob FYI

@gudrutis
Copy link
Contributor

@fabiocos , code checks will not work since it is an old release where we don't have Clang Id.

@fabiocos
Copy link
Contributor Author

@gudrutis ok thanks for recalling me...

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33586/console Started: 2019/03/14 06:07

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26168/33586/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 110
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721221
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@civanch
Copy link
Contributor

civanch commented Mar 14, 2019

+1

@fabiocos
Copy link
Contributor Author

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_MAOD_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

+1

the DQM differences look unrelated to this PR

@cmsbuild cmsbuild merged commit 8d6e9fa into cms-sw:CMSSW_9_4_MAOD_X Mar 14, 2019
fabiocos added a commit to fabiocos/cmssw that referenced this pull request Apr 9, 2019
cmsbuild added a commit that referenced this pull request Apr 15, 2019
Import additions for UL from CMSSW_9_4_13_UL1 (#26168) and #26211
@fabiocos fabiocos deleted the fc-ul94X-1 branch December 18, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants