[HGCAL trigger] Configuration updates. New eg ID. Gen macthing selector. Noise threshold. #26545

jbsauvan · 2019-04-26T12:53:03Z

PR description:

Add egamma cluster id for the "histomax" clustering
Add gen-matched cluster selector
Refactor configurations and customisations to better handle multiple algorithms and era modifications
Add sensor cell threshold at 3sigma of the noise before summing sensor cells into trigger cells

Needs external cms-data/L1Trigger-L1THGCal#13

PR validation:

scram b code-checks
scram b code-format
runTheMatrix.py -w upgrade -l 21234.0 --maxSteps=2
runTheMatrix.py -w upgrade -l 27434.0 --maxSteps=2
runTheMatrix.py -w upgrade -l 29034.0 --maxSteps=2

cmsbuild · 2019-04-26T12:53:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-26T12:59:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26545/9442

This PR adds an extra 40KB to repository

cmsbuild · 2019-04-26T12:59:52Z

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

L1Trigger/L1THGCal
L1Trigger/L1THGCalUtilities

@cmsbuild, @rekovic, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

kpedro88

Some simple review comments while waiting for the external data update

kpedro88 · 2019-04-26T14:28:11Z

L1Trigger/L1THGCal/interface/veryfrontend/HGCalVFESummationImpl.h


 private:
  std::vector<double> thickness_corrections_;
+  double LSB_silicon_fC_;


member variable names should start with lower case

kpedro88 · 2019-04-26T14:31:06Z

L1Trigger/L1THGCal/python/customClustering.py

+                                 ):
+    parameters_c2d = distance_C2d_params.clone()
+    set_threshold_params(parameters_c2d, seed_threshold, cluster_threshold)
+    parameters_c2d.dR_cluster = distance


parameters can be reset inside the clone() statement (everywhere in this file)

kpedro88 · 2019-04-26T14:32:00Z

L1Trigger/L1THGCal/python/customIdentification.py

+            raise KeyError('HGC TPG ID: Cannot find a cut corresponding to the working point {}'.format(wp))
+    parameters_c3d = process.hgcalBackEndLayer2Producer.ProcessorParameters.C3d_parameters
+    identification = egamma_identification_histomax.clone()
+    identification.WorkingPoints = cms.vdouble(


can be done inside clone()

kpedro88 · 2019-04-26T14:33:35Z

L1Trigger/L1THGCal/python/customTriggerCellSelect.py

+                                       threshold_scintillator=threshold_conc_proc.triggercell_threshold_scintillator  # in mipT
+                                       ):
+    parameters = threshold_conc_proc.clone()
+    parameters.triggercell_threshold_silicon = threshold_silicon


can be done inside clone() (everywhere in this file)

kpedro88 · 2019-04-26T14:35:30Z

L1Trigger/L1THGCal/python/hgcalBackEndLayer1Producer_cfi.py

+# (see https://indico.cern.ch/event/806845/contributions/3359859/attachments/1815187/2966402/19-03-20_EGPerf_HGCBE.pdf
+# for more details)
+phase2_hgcalV9.toModify(c2d_thresholds_pset,
+                        seeding_threshold_silicon=cms.double(3.75),


better to avoid using cms.double() in toModify(), e.g. seeding_threshold_silicon = 3.75 (to check automatically if the assigned value has the right type vs. the original value)

kpedro88 · 2019-04-26T14:37:28Z

L1Trigger/L1THGCal/python/hgcalBackEndLayer2Producer_cfi.py

+# (see https://indico.cern.ch/event/806845/contributions/3359859/attachments/1815187/2966402/19-03-20_EGPerf_HGCBE.pdf
+# for more details)
+phase2_hgcalV9.toModify(histoMax_C3d_params,
+                        threshold_histo_multicluster=cms.double(7.5),  # MipT


better to avoid using cms.double() in toModify()

kpedro88 · 2019-04-26T14:37:35Z

L1Trigger/L1THGCal/python/hgcalBackEndLayer2Producer_cfi.py

+
+
+histoMaxVariableDR_C3d_params = histoMax_C3d_params.clone()
+histoMaxVariableDR_C3d_params.dR_multicluster = cms.double(0.)


can be done inside clone() (everywhere in this file)

kpedro88 · 2019-04-26T14:37:46Z

L1Trigger/L1THGCal/python/hgcalConcentratorProducer_cfi.py

+# (see https://indico.cern.ch/event/806845/contributions/3359859/attachments/1815187/2966402/19-03-20_EGPerf_HGCBE.pdf
+# for more details)
+phase2_hgcalV9.toModify(threshold_conc_proc,
+                        triggercell_threshold_silicon=cms.double(1.5),  # MipT


better to avoid using cms.double() in toModify()

kpedro88 · 2019-04-26T14:38:59Z

L1Trigger/L1THGCal/src/veryfrontend/HGCalVFESummationImpl.cc

+      LSB_scintillator_MIP_(conf.getParameter<double>("scintillatorCellLSB_MIP")),
+      thresholds_silicon_(conf.getParameter<std::vector<double>>("thresholdsSilicon")),
+      threshold_scintillator_(conf.getParameter<double>("thresholdScintillator")) {
+  if (thickness_corrections_.size() != 3) {


magic number 3 should be named constant

kpedro88 · 2019-04-26T14:39:56Z

L1Trigger/L1THGCalUtilities/plugins/selectors/HGC3DClusterGenMatchSelector.cc

+}
+
+void l1t::HGC3DClusterGenMatchSelector::produce(edm::Event &iEvent, const edm::EventSetup &) {
+  std::unique_ptr<l1t::HGCalMulticlusterBxCollection> out(new l1t::HGCalMulticlusterBxCollection());


use std::make_unique

cmsbuild · 2019-04-27T09:48:47Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-27T09:55:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26545/9460

This PR adds an extra 72KB to repository

cmsbuild · 2019-04-27T09:55:45Z

Pull request #26545 was updated. @cmsbuild, @rekovic, @kpedro88 can you please check and sign again.

jbsauvan · 2019-04-27T09:55:48Z

Thanks @kpedro88 , comments have been addressed.

rekovic · 2019-05-02T07:08:07Z

please test

cmsbuild · 2019-05-02T07:08:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34454/console Started: 2019/05/02 09:09

cmsbuild · 2019-05-02T09:42:42Z

-1

Tested at: a40da35

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26545/34454/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

27434.0 step2

runTheMatrix-results/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35.log

29034.0 step2

runTheMatrix-results/29034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D41+RecoFullGlobal_2023D41+HARVESTFullGlobal_2023D41.log

cmsbuild · 2019-05-02T09:42:47Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2019-05-03T18:45:39Z

+1
Tested at: 659902c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26545/34478/summary.html

cmsbuild · 2019-05-03T18:45:48Z

Comparison job queued.

cmsbuild · 2019-05-03T20:42:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26545/34478/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3211964
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211759
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

kpedro88 · 2019-05-06T15:31:44Z

+upgrade

rekovic · 2019-05-07T08:36:02Z

+1

cmsbuild · 2019-05-07T08:36:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-05-08T07:51:59Z

+1

cmsbuild added this to the CMSSW_10_6_X milestone Apr 26, 2019

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending upgrade-pending labels Apr 26, 2019

jbsauvan mentioned this pull request Apr 26, 2019

List of integrations PFCal-dev/cmssw#44

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 26, 2019

kpedro88 reviewed Apr 26, 2019

View reviewed changes

jbsauvan added a commit to PFCal-dev/cmssw that referenced this pull request Apr 27, 2019

Implement comments PR cms-sw#26545

a40da35

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 27, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 27, 2019

cmsbuild added tests-started and removed tests-pending labels May 2, 2019

cmsbuild added requires-external tests-started labels May 3, 2019

cmsbuild added tests-approved and removed tests-started labels May 3, 2019

cmsbuild added comparison-available and removed comparison-pending labels May 3, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels May 6, 2019

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels May 7, 2019

cmsbuild added orp-approved and removed orp-pending labels May 8, 2019

cmsbuild merged commit c43e052 into cms-sw:master May 8, 2019

This was referenced May 16, 2019

improvements to the HGCHEback digitizer and implementation of a end-of-life scenario for the HGC scintillator section #26380

Closed

improvements to the HGCHEback digitizer and implementation of a end-of-life scenario for the HGC scintillator section #26811

Merged

jbsauvan added a commit to jbsauvan/cmssw that referenced this pull request May 17, 2019

Implement comments PR cms-sw#26545

4f94868

jbsauvan mentioned this pull request May 17, 2019

Backport comments PR #26545 PFCal-dev/cmssw#342

Merged

jbsauvan added a commit to PFCal-dev/cmssw that referenced this pull request May 17, 2019

Implement comments PR cms-sw#26545

f1fad5e

jbsauvan added a commit to PFCal-dev/cmssw that referenced this pull request May 17, 2019

Implement comments PR cms-sw#26545

9f7b2d8

jbsauvan added a commit to PFCal-dev/cmssw that referenced this pull request May 17, 2019

Implement comments PR cms-sw#26545

6fc7651

jbsauvan mentioned this pull request Nov 29, 2021

Archived Integrations hgc-tpg/cmssw#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HGCAL trigger] Configuration updates. New eg ID. Gen macthing selector. Noise threshold. #26545

[HGCAL trigger] Configuration updates. New eg ID. Gen macthing selector. Noise threshold. #26545

jbsauvan commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

kpedro88 left a comment

kpedro88 Apr 26, 2019

kpedro88 Apr 26, 2019

kpedro88 Apr 26, 2019

kpedro88 Apr 26, 2019

kpedro88 Apr 26, 2019

kpedro88 Apr 26, 2019

kpedro88 Apr 26, 2019

kpedro88 Apr 26, 2019

kpedro88 Apr 26, 2019

kpedro88 Apr 26, 2019

cmsbuild commented Apr 27, 2019

cmsbuild commented Apr 27, 2019

cmsbuild commented Apr 27, 2019

jbsauvan commented Apr 27, 2019

rekovic commented May 2, 2019

cmsbuild commented May 2, 2019 •

edited

cmsbuild commented May 2, 2019

cmsbuild commented May 2, 2019

cmsbuild commented May 3, 2019

cmsbuild commented May 3, 2019

cmsbuild commented May 3, 2019

kpedro88 commented May 6, 2019

rekovic commented May 7, 2019

cmsbuild commented May 7, 2019

fabiocos commented May 8, 2019



		histoMaxVariableDR_C3d_params = histoMax_C3d_params.clone()
		histoMaxVariableDR_C3d_params.dR_multicluster = cms.double(0.)

[HGCAL trigger] Configuration updates. New eg ID. Gen macthing selector. Noise threshold. #26545

[HGCAL trigger] Configuration updates. New eg ID. Gen macthing selector. Noise threshold. #26545

Conversation

jbsauvan commented Apr 26, 2019

PR description:

PR validation:

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

kpedro88 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Apr 27, 2019

cmsbuild commented Apr 27, 2019

cmsbuild commented Apr 27, 2019

jbsauvan commented Apr 27, 2019

rekovic commented May 2, 2019

cmsbuild commented May 2, 2019 • edited

cmsbuild commented May 2, 2019

cmsbuild commented May 2, 2019

cmsbuild commented May 3, 2019

cmsbuild commented May 3, 2019

cmsbuild commented May 3, 2019

kpedro88 commented May 6, 2019

rekovic commented May 7, 2019

cmsbuild commented May 7, 2019

fabiocos commented May 8, 2019

cmsbuild commented May 2, 2019 •

edited