improvements to the HGCHEback digitizer and implementation of a end-of-life scenario for the HGC scintillator section

[deguio]

this is a copy of PR #26380 which I cannot re-open.
reporting here PR description. sorry for the troubles..

---

PR description:

this PR implements a more realistic version of the HGC HE-back digitizer:

• updated parameters, closer to the current design of the HGC HE-back section, are included
• switches are added to choose the digi algorithm and enable the dependence of the signal on the scintillator tile geometry
• a first implementation of a end-of-life scenario (3000/fb, 16.7kh) for HGC HE-back is implemented. the scenario is automatically enabled when the appropriate custom function defined in aging.py is called
• a standalone analyzer is added to allow a simplified plotting of the dose, fluence and SoN maps

the references that support this implementation are:

• Notes from Philippe (mid 2018)
• DN from Jeremy/Pawel (early 2017)
• Notes from Chris (early 2019)
• Dose and Fluence parametrization by Jeremy (April 2019)
• CMS-TDR-019

This set of changes will allow to study the evolution of occupancy and bandwidth for a end-of-life configuration of the HGC scintillating section.

PR validation:

A full validation was presented at the HGCal DPG

in summary:

• small differences are expected for a non-aged scenario
• an improved description of the signal and noise evolution is included depending from cell location, scintillator darkening and dark current for a end-of-life scenario
• the implementation is not expected to affect dramatically the recHit energy scale

in terms of performance here is the impact of this PR on the HGC HE-back digitization:

• current version
• new implementation, begin of life
• new implementation, end of life
• new implementation, end of life, after commit 4a52c5eb25d
• new implementation, end of life, after commit dc5acc22b2b
• new implementation, v10 on 10_6_0_pre4, end of life, after commit 5c42c3cad85

@pfs @perrotta

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26811/9825

• This PR adds an extra 84KB to repository

• Found files with invalid states:

  • SimCalorimetry/HGCalSimProducers/data/doseParams_3000fb.txt:
    • Added: d56edec
    • Modified: 875d7fe, 7222ea4
    • Deleted: 625bdda

[cmsbuild]

A new Pull Request was created by @deguio (Federico De Guio) for master.

It involves the following packages:

RecoLocalCalo/HGCalRecProducers
SimCalorimetry/HGCalSimProducers
SimCalorimetry/HcalSimAlgos
SimGeneral/MixingModule

@perrotta, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @makortel, @felicepantaleo, @rovere, @lgray, @cseez, @pfs, @mariadalfonso, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

Before launching the tests, please @deguio apply the fixes in the PSet in
https://github.com/cms-sw/cmssw/blob/master/L1Trigger/L1THGCal/python/hgcalVFEProducer_cfi.py#L50
(as it was modified after #26545): in this PR the paramenter HGCAL_noise_MIP is renamed

Please also run some test and verify whether there are also other modification from #26545 or from some other recent commit that need to be fixed to comply with what you are implementing here,

[cmsbuild]

The code-checks are being triggered in jenkins.

[deguio]

I've pushed the change and tested WF 29034.0 and it runs fine.
however from what I see the vfe_proc as it is doesn't see the effect of the functions in hgcalDigitizer_cfi.py in case they are called.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26811/9833

• This PR adds an extra 92KB to repository

• Found files with invalid states:

  • SimCalorimetry/HGCalSimProducers/data/doseParams_3000fb.txt:
    • Added: d56edec
    • Modified: 875d7fe, 7222ea4
    • Deleted: 625bdda

[cmsbuild]

Pull request #26811 was updated. @perrotta, @civanch, @kpedro88, @cmsbuild, @rekovic, @mdhildreth, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/296/console Started: 2019/05/17 11:27

[cmsbuild]

+1
Tested at: a295a7e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a10c2/822/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a10c2/822/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 9990 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3215458
• DQMHistoTests: Total failures: 6470
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3208654
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• Only rebased since previous reco signature in improvements to the HGCHEback digitizer and implementation of a end-of-life scenario for the HGC scintillator section #26811 (comment):
  • Changes in reco code are minor and consequential to the changes in simulation
  • Jenkins outputs and validation plots provided reflect all that
  • Performance as reported in the PR description in terms of CPU is good

[fabiocos]

@rekovic @civanch @kpedro88 I understand that this PR was already signed by all of you, and the latest updated after rebase is in the RECO area and is ok. I will move forward with the integration, please comment in case for further updates.

[fabiocos]

I see that this PR touches the same files as other open PRs:

File  RecoLocalCalo/HGCalRecProducers/interface/HGCalCLUEAlgo.h  modified in PRs #  ['27128', '26811']
File  RecoLocalCalo/HGCalRecProducers/interface/HGCalImagingAlgo.h  modified in PRs #  ['27049', '27128', '26811']
File  RecoLocalCalo/HGCalRecProducers/plugins/HGCalRecHitWorkerSimple.cc  modified in PRs #  ['27129', '26811']

but for what I can see the lines are different, so I do not expect conflicts when this is merged

[kpedro88]

+upgrade

[civanch]

+1

[fabiocos]

+1

[fabiocos]

merge