Commits on Apr 26, 2019

1. Bug fixes for EventSetup consumes corner cases …

   Fixes 2 bugs. One causes an assert failure and the other an out
   of bounds read. These bugs were only introduced recently and
   only in 10_6_X. I am not aware of any existing code that actually
   hits these corner cases. The assert occurs after a call to
   setWhatProduced for multiple products followed by another call
   to setWhatProduced. The out of bounds read failure occurs when
   esConsumes is called for mutiple types of transitions (event,
   beginRun, ...) in the same producer, filter, or analyzer.
   
   Modifies existing unit tests so the assert bug would now fail
   a unit test. Modified another test to hit the out of bounds read,
   although you need valgrind to actually see it with this test, but
   there is a more involved tests coming soon in the PR that implements
   concurrent IOVs that fails with the out of bounds read bug. These
   bugs were noticed while testing the concurrent IOV PR.

   

   wddgit committed Apr 26, 2019
   Copy the full SHA

   115caea View commit details

   Browse the repository at this point in the history