Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary calls to vector::empty() and vector::clear() from CmsTrackerPhase{1,2TP}DiskBuilder #26553

Merged
merged 1 commit into from Apr 29, 2019
Merged

Remove unnecessary calls to vector::empty() and vector::clear() from CmsTrackerPhase{1,2TP}DiskBuilder #26553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions Geometry/TrackerNumberingBuilder/plugins/CmsTrackerPhase1DiskBuilder.cc
View file
Open in desktop
Expand Up @@ -26,8 +26,6 @@ CmsTrackerPhase1DiskBuilder::PhiPosNegSplit_innerOuter( std::vector< GeometricDe

// now put positive phi (in order) ahead of negative phi as in std geometry
std::vector<const GeometricDet*> theCompsPosNeg;
theCompsPosNeg.empty();
theCompsPosNeg.clear();
// also find the average radius (used to split inner and outer disk panels)
double theRmin = (**begin).rho();
double theRmax = theRmin;
Expand All @@ -47,8 +45,6 @@ CmsTrackerPhase1DiskBuilder::PhiPosNegSplit_innerOuter( std::vector< GeometricDe
// force the split radius to be 100 mm to be able to deal with disks with only outer ring
double radius_split = 100.;
std::vector<const GeometricDet*> theCompsInnerOuter;
theCompsInnerOuter.empty();
theCompsInnerOuter.clear();
unsigned int num_inner = 0;
for(vector<const GeometricDet*>::const_iterator it=theCompsPosNeg.begin();
it!=theCompsPosNeg.end();it++){
Expand Down
4 changes: 0 additions & 4 deletions Geometry/TrackerNumberingBuilder/plugins/CmsTrackerPhase2TPDiskBuilder.cc
View file
Open in desktop
Expand Up @@ -26,8 +26,6 @@ CmsTrackerPhase2TPDiskBuilder::PhiPosNegSplit_innerOuter( std::vector< Geometric

// now put positive phi (in order) ahead of negative phi as in std geometry
std::vector<const GeometricDet*> theCompsPosNeg;
theCompsPosNeg.empty();
theCompsPosNeg.clear();
// also find the average radius (used to split inner and outer disk panels)
double theRmin = (**begin).rho();
double theRmax = theRmin;
Expand All @@ -47,8 +45,6 @@ CmsTrackerPhase2TPDiskBuilder::PhiPosNegSplit_innerOuter( std::vector< Geometric
// force the split radius to be 100 mm to be able to deal with disks with only outer ring
double radius_split = 100.;
std::vector<const GeometricDet*> theCompsInnerOuter;
theCompsInnerOuter.empty();
theCompsInnerOuter.clear();
unsigned int num_inner = 0;
for(vector<const GeometricDet*>::const_iterator it=theCompsPosNeg.begin();
it!=theCompsPosNeg.end();it++){
Expand Down