Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centrality plugins and DQM centrality bugfixes #2658

Merged
merged 4 commits into from Feb 28, 2014

Conversation

yetkinyilmaz
Copy link
Contributor

Bug fixes for :
#1564 (comment)
and
#2547 (comment)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yetkinyilmaz for CMSSW_5_3_X.

Centrality plugins and DQM centrality bugfixes

It involves the following packages:

DQM/Physics
RecoHI/HiCentralityAlgos

@thspeer, @danduggan, @rovere, @cmsbuild, @anton-a, @nclopezo, @deguio, @slava77, @Degano, @ojeda can you please review it and eventually sign? Thanks.
@azsigmon, @jazzitup, @yenjie, @kurtejung, @mandrenguyen, @richard-cms this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@smuzaffar
Copy link
Contributor

and what about RecoHI/HiCentralityAlgos/interface/CentralityTableHandler.h RecoHI/HiCentralityAlgos/src/CentralityTableHandler.cc
No one uses RecoHI/HiCentralityAlgos/interface/CentralityTableHandler.h except src/CentralityTableHandler.cc and it declares CentralityPopConProducer pluguin. So I would suggest to move both these 2 files to RecoHI/HiCentralityAlgos/plugins directory too

@smuzaffar
Copy link
Contributor

Oops I see you have move RecoHI/HiCentralityAlgos/src/CentralityTableHandler.cc, but can you move RecoHI/HiCentralityAlgos/interface/CentralityTableHandler.h too? no one outside this package uses it.

@smuzaffar
Copy link
Contributor

+tested
I will include it once RecoHI/HiCentralityAlgos/interface/CentralityTableHandler.h is also move to plugins directory

@smuzaffar
Copy link
Contributor

@yetkinyilmaz, I am still waiting for this interface/CentralityTableHandler.h -> plugins/CentralityTableHandler.h move
@davidlange6, once we have this included then I think we are ready to build heavy ion re-reco release

@cmsbuild
Copy link
Contributor

Pull request #2658 was updated. @thspeer, @danduggan, @rovere, @cmsbuild, @anton-a, @nclopezo, @deguio, @slava77, @Degano, @ojeda can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #2658 was updated. @thspeer, @danduggan, @rovere, @cmsbuild, @anton-a, @nclopezo, @deguio, @slava77, @Degano, @ojeda can you please check and sign again.

@smuzaffar
Copy link
Contributor

+tested
I am by passing this as it is just a technical change to fix the duplicate plugin issue+simple fix for #2547

smuzaffar added a commit that referenced this pull request Feb 28, 2014
Centrality plugins and DQM centrality bugfixes
@smuzaffar smuzaffar merged commit 251f71d into cms-sw:CMSSW_5_3_X Feb 28, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants