[HeaderCheck][RECO][ANA] Cleanup headers to avoid header inconsistency errors

[smuzaffar]

Deleted unused headers from package/interface directory.

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26663/9624

• This PR adds an extra 16KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34536/console Started: 2019/05/06 17:00

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CommonTools/CandAlgos
CommonTools/ParticleFlow
CommonTools/UtilAlgos
PhysicsTools/SelectorUtils

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @ahinzmann, @gkasieczka, @cbernet, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 0d5db10
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26663/34536/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26663/34536/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

• The removed "CommonTools/CandAlgos/interface/NamedCandCombiner.h" is the only user of the "CommonTools/CandUtils/interface/NamedCandCombiner.h" class. As such, one could also remove
  • CommonTools/CandUtils/interface/NamedCandCombiner.h
  • CommonTools/CandUtils/interface/NamedCandCombinerBase.h
  • CommonTools/CandUtils/src/NamedCandCombiner.cc

Not clear whether they may still have any usage in analysis or private code, though...

• "CommonTools/ParticleFlow/interface/TopProjectors.h" and "CommonTools/ParticleFlow/interface/TopProjectorAlgo.h" look like being replaced by "CommonTools/ParticleFlow/interface/TopProjector.h" since 5_3 at least: ok to remove

• "CommonTools/UtilAlgos/interface/ChargeSelector.h" includes obsolete headers (since 5_3 at least) and it can be removed

• "CommonTools/UtilAlgos/interface/ObjectCounter.h" has no usage inside cmssw (since 5_3 at least), but I don't know how to verify whether it is still used in analysis or private code

• "PhysicsTools/SelectorUtils/interface/Expressions.h" has no usage inside cmssw (since 5_3 at least), but I don't know how to verify whether it is still used in analysis or private code

[fabiocos]

@santocch do you know whether there is any potential analysis use of the headers marked by @perrotta ?

[perrotta]

@smuzaffar @santocch , since the 11_0 queue is now open, one could try to remove all those headers. quite likely all really unneeded, and possibly restore them later only in case of need in analysis code.

@smuzaffar by the way, do you plan to remove also the files in CommonTools/CandUtils (see first bullet in #26663 (comment))?

[smuzaffar]

@perrotta for now I want to get headers checks clean so that we can mark PR tests failed if there are inconsistent headers that is why I was not touch other files.

May be we can do another round of headers cleanup for all those headers which are not included in any cc file.

[perrotta]

+1

• All removed headers seem obsolete enough to be safely removed in 11_0_X
• Jenkins tests pass

[fabiocos]

@santocch I move forward with the integration as no comment so far, in case please post notes

[fabiocos]

+1

[fabiocos]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.