Modernized Geometry/CmsTrackerDetIdBuilder #26685
Conversation
-pass by reference instead of pointer since can never be nullptr -pass std::vector by const reference not by value
-removed all state since unnecessary -made only function static -function takes references and returns std::unique_ptr to properly handle memory.
-added consumes -made member data function local since their values are not needed between produce calls.
-made only function static -function now return std::unique_ptr to make ownership clear.
-Use consumes -Updated to new helper class APIs
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26685/9657
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: Geometry/TrackerNumberingBuilder @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
This is part of #26584 |
|
Pull request #26685 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
|
@smuzaffar I added the comment after the comparison was finished and this triggered the code checks. Any idea why? |
|
@Dr15Jones , looks like a bug in bot. code-checks should have automatically triggered when you push new changes while comparison was running for aa51d27 |
|
@Dr15Jones , something strange with your commits. You opened the PR 22 hours ago while the commits are 18 to 17 hours old. That could have confused bot. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
-Added consumes to ES modules
-Use references instead of pointers in APIs where pointers were always assumed to be non null
PR validation:
The code compiles.