Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernized Geometry/CmsTrackerDetIdBuilder #26685

Merged
merged 6 commits into from May 15, 2019
Merged

Modernized Geometry/CmsTrackerDetIdBuilder #26685

merged 6 commits into from May 15, 2019

Commits on May 7, 2019

  1. Better argument passing in CmsTrackerDetIdBuilder 

    -pass by reference instead of pointer since can never be nullptr
-pass std::vector by const reference not by value
    @Dr15Jones
    Dr15Jones committed May 7, 2019
    Configuration menu
    Copy the full SHA
    bc35d7c View commit details
    Browse the repository at this point in the history

  2. Improved API for DDDCmsTrackerContruction 

    -removed all state since unnecessary
-made only function static
-function takes references and returns std::unique_ptr to properly
 handle memory.
    @Dr15Jones
    Dr15Jones committed May 7, 2019
    Configuration menu
    Copy the full SHA
    213a835 View commit details
    Browse the repository at this point in the history

  3. Modernized TrackerTopologyEP 

    -added consumes
-made member data function local since their values are not needed
 between produce calls.
    @Dr15Jones
    Dr15Jones committed May 7, 2019
    Configuration menu
    Copy the full SHA
    7153250 View commit details
    Browse the repository at this point in the history

  4. Improved API for CondDBCmsTrackerConstruction 

    -made only function static
-function now return std::unique_ptr to make ownership clear.
    @Dr15Jones
    Dr15Jones committed May 7, 2019
    Configuration menu
    Copy the full SHA
    958392a View commit details
    Browse the repository at this point in the history

  5. Modernize TrackerGeometricDetESModule 

    -Use consumes
-Updated to new helper class APIs
    @Dr15Jones
    Dr15Jones committed May 7, 2019
    Configuration menu
    Copy the full SHA
    ae1ebe6 View commit details
    Browse the repository at this point in the history

  6. Added consumes calls to TrackerGeometricDetExtraESModule

    @Dr15Jones
    Dr15Jones committed May 7, 2019
    Configuration menu
    Copy the full SHA
    aa51d27 View commit details
    Browse the repository at this point in the history