Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTV : adjust impact parameter selection #26700

Merged
merged 4 commits into from May 15, 2019
Merged

MTV : adjust impact parameter selection #26700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cdaab3
adjust impact parameter selection for avoiding the 1st layer of the p…
mtosi May 8, 2019
62fd7cd
update
mtosi May 8, 2019
860c38a
fix
mtosi May 8, 2019
9cac0ed
fix
mtosi May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 28 additions & 0 deletions Validation/RecoTrack/python/GenParticleSelectionsForEfficiency_cff.py
View file
Open in desktop
Expand Up @@ -10,6 +10,10 @@
tipGP = cms.double(60),
statusGP = cms.int32(1)
)
from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel
from Configuration.Eras.Modifier_phase2_tracker_cff import phase2_tracker
phase1Pixel.toModify(GenParticleSelectionForEfficiency,minRapidityGP = -3.0, maxRapidityGP = 3.0)
phase2_tracker.toModify(GenParticleSelectionForEfficiency,minRapidityGP = -4.5, maxRapidityGP = 4.5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably good to update this file, even if MultiTrackValidatorGenPs has been largely unsupported (at least) for the past ~4.5 years (it might still work though).


generalGpSelectorBlock = cms.PSet(
status = cms.int32(1),
Expand Down Expand Up @@ -77,3 +81,27 @@
lip = cms.double(35.0),
tip = cms.double(3.5)
)

def _modifyForPhase1(pset):
pset.minRapidity = -3
pset.maxRapidity = 3
pset.tip = 2.5 # beampipe is around 2.0, BPIX1 is at 2.9
from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel
phase1Pixel.toModify(generalGpSelectorBlock, _modifyForPhase1)
phase1Pixel.toModify(GpSelectorForEfficiencyVsEtaBlock, _modifyForPhase1)
phase1Pixel.toModify(GpSelectorForEfficiencyVsPhiBlock, _modifyForPhase1)
phase1Pixel.toModify(GpSelectorForEfficiencyVsPtBlock, _modifyForPhase1)
phase1Pixel.toModify(GpSelectorForEfficiencyVsVTXRBlock, _modifyForPhase1)
phase1Pixel.toModify(GpSelectorForEfficiencyVsVTXZBlock, _modifyForPhase1)

def _modifyForPhase2(pset):
pset.minRapidity = -4.5
pset.maxRapidity = 4.5
pset.tip = 2.5 # IT1 will be around 3.0 (as in Phase1)
from Configuration.Eras.Modifier_phase2_tracker_cff import phase2_tracker
phase2_tracker.toModify(generalGpSelectorBlock, _modifyForPhase2)
phase2_tracker.toModify(GpSelectorForEfficiencyVsEtaBlock, _modifyForPhase2)
phase2_tracker.toModify(GpSelectorForEfficiencyVsPhiBlock, _modifyForPhase2)
phase2_tracker.toModify(GpSelectorForEfficiencyVsPtBlock, _modifyForPhase2)
phase2_tracker.toModify(GpSelectorForEfficiencyVsVTXRBlock, _modifyForPhase2)
phase2_tracker.toModify(GpSelectorForEfficiencyVsVTXZBlock, _modifyForPhase2)
5 changes: 5 additions & 0 deletions Validation/RecoTrack/python/MultiTrackValidatorGenPs_cfi.py
View file
Open in desktop
Expand Up @@ -69,3 +69,8 @@
doRecoTrackPlots = cms.untracked.bool(True),
dodEdxPlots = cms.untracked.bool(False),
)

from Configuration.ProcessModifiers.premix_stage2_cff import premix_stage2
premix_stage2.toModify(multiTrackValidator,
label_tv = "mixData:MergedTrackTruth",
)
12 changes: 10 additions & 2 deletions Validation/RecoTrack/python/TrackingParticleSelectionsForEfficiency_cff.py
View file
Open in desktop
Expand Up @@ -29,9 +29,17 @@
def _modifyForPhase1(pset):
pset.minRapidity = -3
pset.maxRapidity = 3
pset.tip = 2.5 # beampipe is around 2.0, BPIX1 is at 2.9

from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel
phase1Pixel.toModify(generalTpSelectorBlock, _modifyForPhase1)
phase1Pixel.toModify(TpSelectorForEfficiencyVsEtaBlock, _modifyForPhase1)

def _modifyForPhase2(pset):
pset.minRapidity = -4.5
pset.maxRapidity = 4.5
pset.tip = 2.5 # IT1 will be around 3.0 (as in Phase1)

from Configuration.Eras.Modifier_phase2_tracker_cff import phase2_tracker
phase2_tracker.toModify(generalTpSelectorBlock, minRapidity=-4.5, maxRapidity=4.5)
phase2_tracker.toModify(TpSelectorForEfficiencyVsEtaBlock, minRapidity=-4.5, maxRapidity=4.5)
phase2_tracker.toModify(generalTpSelectorBlock, _modifyForPhase2)
phase2_tracker.toModify(TpSelectorForEfficiencyVsEtaBlock, _modifyForPhase2)