Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 106X global tags in data and 2021/2023 MC #26773

Merged
merged 5 commits into from May 22, 2019

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR updates offline, prompt-like and 2021 MC global tags in 10_6_X.

Run I and Run II data

Update of PPS conditions [1], HCAL response corrections [2], pixel/tracker conditions [3] for 2017 UL reprocessing.

Diffs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_v11/106X_dataRun2_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_relval_v10/106X_dataRun2_relval_v9

[1] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4136.html
[2] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4132/1.html
[3] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4117/1.html

Prompt-like Data

Update of PPS conditions [1].

[1] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4136.html

Diffs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_v7/106X_dataRun2_PromptLike_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_HI_v7/106X_dataRun2_PromptLike_HI_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_HEfail_v6/106X_dataRun2_PromptLike_HEfail_v5

2021 MC

2021 MC is based on the best 2018 conditions available (106X_upgrade2018_realistic_v4), but with several other changes:

  • Modified HCAL tags to incorporate updated geometry, including updated energy scale for upgraded HB
  • Updated beam spot (round optics, high sigmaZ)
  • Ideal CSC and pixel conditions

[1]

Diffs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021_design_v1/106X_postLS2_design_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021_realistic_v4/106X_postLS2_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021cosmics_realistic_deco_v2/106X_upgrade2021cosmics_realistic_deco_v1

PR validation:

Please see the links inline above for details of the validation. In addition, this PR includes a GT update that should resolve #24795 (comment).

A dedicated RelVal campaign for the 2021 realistic MC GT is underway.

Matrix tests have also been performed:

runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26773/9771

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/201/console Started: 2019/05/14 11:13

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1a6c0/201/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4389 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212004
  • DQMHistoTests: Total failures: 6180
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 3205613
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 136.788 ): 0.008 KiB JetMET/SUSYDQM
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@tocheng
Copy link
Contributor

tocheng commented May 14, 2019

@christopheralanwest
As master moves to 11_0_X, this PR needs backport to 10_6.
Thanks.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26773/9890

  • This PR adds an extra 16KB to repository

@christopheralanwest
Copy link
Contributor Author

The conflict was trivial: PR #26828 did not update the strings to remove the phrase "postLS2" from the comments (that is, it wasn't really a cherry-pick of the relevant commit from this PR), but the GTs were the same.

@cmsbuild
Copy link
Contributor

Pull request #26773 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please check and sign again.

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/374/console Started: 2019/05/21 14:46

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1a6c0/374/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14645 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3206828
  • DQMHistoTests: Total failures: 15381
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3191107
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 136.788 ): 0.008 KiB JetMET/SUSYDQM
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

The only differences in the comparison tests are seen in the 2021 scenario, which differs because the recently merged PR #26828 changes the default 2021 MC SIM beamspot from Realistic25ns13TeVEarly2017Collision to Run3RoundOptics25ns13TeVHighSigmaZ.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 298a9fc into cms-sw:master May 22, 2019
@christopheralanwest christopheralanwest deleted the alca-106X-gt branch August 21, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add/update highBetaStar 2018 workflows with a physics data run
6 participants