Remove outdated tau code

[steggema]

PR description:

This removes a lot of outdated and unused tau code, in particular the full package RecoTauTag/TauTagTools and the CaloTau reconstruction. The goal is do make tau development easier and to reduce the maintenance burden. No changes are expected in any of the workflows.

PR validation:

Matrix tests were run locally as well as the tau reconstruction sequence itself to validate that there are no unwanted effects. The changes were reviewed by the RECO contacts @mbluj @swozniewski, also to confirm that there are no customers outside of CMSSW to the best of our knowledge.

@rmanzoni @roger-wolf

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26816/9834

• This PR adds an extra 52KB to repository

• Found files with invalid states:

  • RecoTauTag/RecoTau/src/PFRecoTauTagInfoAlgorithm.cc:
    • Deleted: 95befb4
    • Added: 1f9b1ac
  • RecoTauTag/RecoTau/plugins/PFRecoTauTagInfoProducer.cc:
    • Deleted: 95befb4
    • Added: 1f9b1ac
  • RecoTauTag/RecoTau/interface/PFRecoTauTagInfoAlgorithm.h:
    • Deleted: 95befb4
    • Added: 1f9b1ac

[cmsbuild]

A new Pull Request was created by @steggema (Jan Steggemann) for master.

It involves the following packages:

CommonTools/ParticleFlow
JetMETCorrections/TauJet
L1Trigger/TrackTrigger
PhysicsTools/PatAlgos
RecoParticleFlow/Benchmark
RecoTauTag/RecoTau
RecoTauTag/TauTagTools
Utilities/ReleaseScripts

@perrotta, @smuzaffar, @Dr15Jones, @kpedro88, @cmsbuild, @rekovic, @slava77, @santocch can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @schoef, @rappoccio, @sviret, @Martin-Grunewald, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @acaudron, @lgray, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @hatakeyamak, @clelange, @HeinerTholen, @wddgit, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @mariadalfonso, @pvmulder, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/295/console Started: 2019/05/17 10:56

[cmsbuild]

-1

Tested at: 68b687c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf1b76/295/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency

• Build:

I found compilation error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-16-2300/src/RecoTauTag/RecoTau/src/RecoTauBinnedIsolationPlugin.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-16-2300/src/RecoTauTag/RecoTau/src/RecoTauCommonUtilities.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-16-2300/src/RecoTauTag/RecoTau/src/RecoTauPluginsCommon.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-16-2300/src/RecoTauTag/RecoTau/interface/RecoTauBinnedIsolationPlugin.h:19:0,
                 from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-16-2300/src/RecoTauTag/RecoTau/src/RecoTauBinnedIsolationPlugin.cc:1:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-16-2300/poison/RecoTauTag/RecoTau/interface/RecoTauDiscriminantPlugins.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-16-2300/src/RecoTauTag/RecoTau/src/RecoTauBinnedIsolationPlugin.cc:1:0:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-16-2300/src/RecoTauTag/RecoTau/interface/RecoTauBinnedIsolationPlugin.h:24:79: error: expected class-name before '{' token
 class RecoTauDiscriminationBinnedIsolation : public RecoTauDiscriminantPlugin {


[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/365/console Started: 2019/05/21 10:41

[cmsbuild]

+1
Tested at: ccfac0e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf1b76/365/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf1b76/365/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3206828
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3206492
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #26816 ccfac0e

• code changes are in line with the PR description and the follow up review.
  • This is a technical PR (no physics results in production setup is affected)
• jenkins tests pass and comparisons with the baseline show no differences

[kpedro88]

+upgrade

[santocch]

+1

[fabiocos]

@rekovic the change for l1 is trivial and just in 1 file
@Dr15Jones @smuzaffar for core this just remove the package from the Utilities list

[smuzaffar]

+core

[fabiocos]

+1

@rekovic the L1 part looks pretty minimal, please check and comment in case, I move forward with the integration

[fabiocos]

merge