New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Photos options #26853
Additional Photos options #26853
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26853/9886
|
A new Pull Request was created by @intrepid42 (Markus Seidel) for master. It involves the following packages: GeneratorInterface/PhotosInterface @alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@intrepid42 Can you elaborate a bit the legends? How can I see the comparisons between the cases with setPairEmission on and off? |
The plots compare Photos ++ single, double, quatro and exponential emission modes with Pythia and QED FSR off. edit: Z_13 = Z->mu+mu-, Z_11 = Z->e+e- I did not check setPairEmission on and off, I will submit some jobs for that and post the plots here! |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@qliphy Please see here the electron multiplicity in Z->mu+mu- events with pair production on/off. Events with 1/2 electrons (= 1 pair) are suppressed by one order of magnitude if pair production is turned off. It seems Photos creates maximal 1 pair while Pythia can do more. |
Look nice to me. Thanks @intrepid42. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Add additional options for Photos++: Enabling of pair production (
setPairEmission
) and ability to continue after rare erroneus events (setStopAtCriticalError
) that would halt production otherwise.PR validation: