New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage PluginFactory plugins with unique_ptr in RecoEgamma #26858
Conversation
Also manage some additional objects with unique_ptr.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26858/9894
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: RecoEgamma/EgammaElectronAlgos @perrotta, @Martin-Grunewald, @cmsbuild, @fwyzard, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
I found an additional case to be generalized (since my initial "search" round in January) within |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26858/9931
|
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 for #26858 ba8515a
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In addition use
unique_ptr
constructor where needed to prepare for PluginFactory returningstd::unique_ptr
.PR validation:
Code compiles.