[RECO] Fixes needed for new root cxxmodules

[smuzaffar]

• Added missing dependency

>grep -R DataFormats/SiStripDigi DataFormats/SiStripCluster
DataFormats/SiStripCluster/interface/SiStripCluster.h:#include "DataFormats/SiStripDigi/interface/SiStripDigi.h"

• Removed usage of pattern ROOT::Math::* from

  cmssw/DataFormats/Math/src/classes_def.xml

  Line 7 in c52e281

  <class pattern="std::vector<ROOT::Math::*>" />

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26883/9916

• This PR adds an extra 16KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/414/console Started: 2019/05/22 12:06

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DataFormats/Math
DataFormats/SiStripCluster

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @makortel, @felicepantaleo, @pieterdavid, @rovere, @VinInn, @alesaggio, @mmusich, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

@slava77 , these can be avoided if we replace the ROOT::Math::* pattern.

[slava77]

do you mean the patterns used in DataFormats/Math/src/classes_def.xml ?
There was some cleanup of dictionaries by the core team a while back to drop the wildcards.
Can that be revived/completed?

[smuzaffar]

yes the pattern in DataFormats/Math/src/classes_def.xml . I am testing the following right now.

-  <class pattern="std::vector<ROOT::Math::*>" />
+  <class pattern="std::vector<ROOT::Math::SMatrix<*>>" />
+  <class pattern="std::vector<ROOT::Math::MatRepStd<*>>" />
+  <class pattern="std::vector<ROOT::Math::RowOffsets<*>>" />
+  <class pattern="std::vector<ROOT::Math::SVector<*>>" />

[cmsbuild]

+1
Tested at: d77bc0a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5cddd/414/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

@slava77 , @perrotta I updated the PR and replace the usage of pattern ROOT::Math::* in classes_def.xml

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/426/console Started: 2019/05/22 17:17

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5cddd/414/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3209204
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3208869
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cmsbuild]

+1
Tested at: c9711ac
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5cddd/426/summary.html
Additional comment: 'Compilation

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5cddd/426/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3206828
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3206493
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #26883 c9711ac

• technical
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[slava77]

ah, so , in #26883 (comment)

Additional comment: 'Compilation

was actually meant to sound a significant alarm. I did not notice it.
I'll try to pay more attention to the summaries.
Although perhaps a bit more verbose message would be better.

[smuzaffar]

It was meant to say "Compilation Warnings: Yes" which should have also added the "warning" label but due to bug in new pr build script it did not post the full message. I will fix this soon.

[fabiocos]

@smuzaffar @slava77 unfortunately I missed it as well...