Modernize ESProducers in CalibTracker/SiPixelESProducers #27042

makortel · 2019-05-31T19:22:44Z

PR description:

This PR modernizes the ESProducers in CalibTracker/SiPixelESProducers (as part of #26748) by

moving contents of the headers to the corresponding source files
using ESGetToken (except for SiPixelGenErrorDBObjectESProducer and SiPixelTemplateDBObjectESProducer that have a non-trivial aspect in them and are dealt separately in [RFC] Migrate SiPixelGenErrorDBObjectESProducer and SiPixelTemplateDBObjectESProducer to EventSetup consumes #27043)
reducing object copies in PixelFedChannelCollectionProducer

PR validation:

Code compiles, no changes expected.

Use ESGetToken, and reduce copying.

- move contents of header to source file - use ESGetToken

- move contents of header to source - remove unused member variable - use ESGetToken

cmsbuild · 2019-05-31T19:23:38Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-05-31T19:28:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27042/10123

This PR adds an extra 20KB to repository

cmsbuild · 2019-05-31T19:30:33Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CalibTracker/SiPixelESProducers

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

makortel · 2019-05-31T19:31:10Z

@cmsbuild, please test

cmsbuild · 2019-05-31T19:31:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/668/console Started: 2019/05/31 21:33

makortel · 2019-05-31T19:32:38Z

CalibTracker/SiPixelESProducers/plugins/SiPixelQualityESProducer.cc

+    }
+  };
+  throwIfNotFound("SiPixelDetVOffRcd");
+  throwIfNotFound("SiPixelQualityFromDbRcd");


I'll be happy to remove these checks if someone could confirm that the ListOfRecordToMerge parameter indeed has no real purpose (anymore?).

@tsusa @mmusich

@makortel Sorry for a slow response. The ListOfRecordToMerge parameter has no real purpose anymore [for SiPixelDetVOffRcd the dummy payload is used].

Thanks @tsusa. I created #27087 to remove these checks and the parameter from the cfi file.

@makortel tnx!

cmsbuild · 2019-05-31T19:36:49Z

-1

Tested at: 14f895c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-981764/668/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

See details on the summary page.

cmsbuild · 2019-05-31T19:36:52Z

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

pohsun · 2019-06-01T09:17:35Z

please test

cmsbuild · 2019-06-01T09:18:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/686/console Started: 2019/06/01 12:07

cmsbuild · 2019-06-01T12:21:46Z

+1
Tested at: edfe70a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-981764/686/summary.html

cmsbuild · 2019-06-01T12:21:50Z

Comparison job queued.

cmsbuild · 2019-06-01T15:19:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-981764/686/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3210678
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3210342
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

pohsun · 2019-06-01T19:18:22Z

+1

cmsbuild · 2019-06-01T19:18:57Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-06-03T08:39:45Z

+1

makortel added 5 commits May 31, 2019 21:20

Modernize PixelFEDChannelCollectionProducer

8f2e023

Use ESGetToken, and reduce copying.

Modernize SiPixel2DTemplateDBObjectESProducer

d5424e1

- move contents of header to source file - use ESGetToken

Modernize SiPixelQualityESProducer

d5c2ba6

- move contents of header to source - remove unused member variable - use ESGetToken

Move contents of SiPixelGenErrorDBObjectESProducer header to source file

3e4dbc4

Move contents of SiPixelTemplateDBObjectESProducer header to source file

14f895c

cmsbuild added this to the CMSSW_11_0_X milestone May 31, 2019

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels May 31, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels May 31, 2019

cmsbuild added tests-started and removed tests-pending labels May 31, 2019

makortel commented May 31, 2019

View reviewed changes

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels May 31, 2019

makortel mentioned this pull request May 31, 2019

[RFC] Migrate SiPixelGenErrorDBObjectESProducer and SiPixelTemplateDBObjectESProducer to EventSetup consumes #27043

Closed

Remove unnecessary lambda capture

edfe70a

cmsbuild added comparison-notrun tests-rejected labels May 31, 2019

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jun 1, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 1, 2019

cmsbuild added tests-approved and removed tests-started labels Jun 1, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 1, 2019

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jun 1, 2019

cmsbuild added orp-approved and removed orp-pending labels Jun 3, 2019

cmsbuild merged commit e9c46bf into cms-sw:master Jun 3, 2019

cmsbuild mentioned this pull request Jun 3, 2019

Fixed incorrect string comparison method in DQM bin by bin comparison tool #27085

Merged

makortel mentioned this pull request Jun 3, 2019

Remove ListOfRecordToMerge configuration parameter from SiPixelQualityESProducer #27087

Merged

cmsbuild mentioned this pull request Jun 3, 2019

Added consumes to GlobalDetLayerGeometryESProducer #27011

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize ESProducers in CalibTracker/SiPixelESProducers #27042

Modernize ESProducers in CalibTracker/SiPixelESProducers #27042

makortel commented May 31, 2019 •

edited

cmsbuild commented May 31, 2019

cmsbuild commented May 31, 2019

cmsbuild commented May 31, 2019

makortel commented May 31, 2019

cmsbuild commented May 31, 2019 •

edited

makortel May 31, 2019

tsusa Jun 1, 2019

makortel Jun 3, 2019

tsusa Jun 4, 2019

cmsbuild commented May 31, 2019

cmsbuild commented May 31, 2019

pohsun commented Jun 1, 2019

cmsbuild commented Jun 1, 2019 •

edited

cmsbuild commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

pohsun commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

fabiocos commented Jun 3, 2019

Modernize ESProducers in CalibTracker/SiPixelESProducers #27042

Modernize ESProducers in CalibTracker/SiPixelESProducers #27042

Conversation

makortel commented May 31, 2019 • edited

PR description:

PR validation:

cmsbuild commented May 31, 2019

cmsbuild commented May 31, 2019

cmsbuild commented May 31, 2019

makortel commented May 31, 2019

cmsbuild commented May 31, 2019 • edited

makortel May 31, 2019

Choose a reason for hiding this comment

tsusa Jun 1, 2019

Choose a reason for hiding this comment

makortel Jun 3, 2019

Choose a reason for hiding this comment

tsusa Jun 4, 2019

Choose a reason for hiding this comment

cmsbuild commented May 31, 2019

cmsbuild commented May 31, 2019

pohsun commented Jun 1, 2019

cmsbuild commented Jun 1, 2019 • edited

cmsbuild commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

pohsun commented Jun 1, 2019

cmsbuild commented Jun 1, 2019

fabiocos commented Jun 3, 2019

makortel commented May 31, 2019 •

edited

cmsbuild commented May 31, 2019 •

edited

cmsbuild commented Jun 1, 2019 •

edited