New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ListOfRecordToMerge configuration parameter from SiPixelQualityESProducer #27087
Remove ListOfRecordToMerge configuration parameter from SiPixelQualityESProducer #27087
Conversation
…yESProducer as obsolete
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27087/10172
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: CalibTracker/SiPixelESProducers @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following the comment #27042 (comment) this PR proposes to remove the
ListOfRecordToMerge
parameter fromSiPixelQualityESProducer
as the parameter is no longer used. I also removed the parameter from thecfi
file, but a larger cleanup on configuration fragments/files could also be done.PR validation:
Code compiles.