Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ListOfRecordToMerge configuration parameter from SiPixelQualityESProducer #27087

Merged
merged 1 commit into from Jun 8, 2019

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jun 3, 2019

PR description:

Following the comment #27042 (comment) this PR proposes to remove the ListOfRecordToMerge parameter from SiPixelQualityESProducer as the parameter is no longer used. I also removed the parameter from the cfi file, but a larger cleanup on configuration fragments/files could also be done.

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27087/10172

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CalibTracker/SiPixelESProducers

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @dkotlins, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Jun 3, 2019

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/731/console Started: 2019/06/03 17:59

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8728dc/731/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3210678
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3210343
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@pohsun
Copy link

pohsun commented Jun 7, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 8, 2019

+1

@cmsbuild cmsbuild merged commit 28b9cc2 into cms-sw:master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants