Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atricomi bladewarn #2708

Merged
merged 1 commit into from Mar 4, 2014
Merged

Conversation

atricomi
Copy link
Contributor

@atricomi atricomi commented Mar 3, 2014

Fix for error message in Extended Pixel Geometry

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2014

A new Pull Request was created by @atricomi (Alessia Tricomi) for CMSSW_6_2_X_SLHC.

Atricomi bladewarn

It involves the following packages:

Geometry/TrackerNumberingBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Mar 4, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link

merge

Tested along with #2706 and #2711. Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000 and 13000 pass all steps. Tests 12200, 12400, 12600, 12800, 13200 and 13400 fail in step 2 with known errors. No more "Number of Blade" warnings as expected.

cmsbuild added a commit that referenced this pull request Mar 4, 2014
@cmsbuild cmsbuild merged commit b81029c into cms-sw:CMSSW_6_2_X_SLHC Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants