Phase2-hgx198 preparing for corner centered wafers

[bsunanda]

PR description:

Changes made in view of wafer centering vs corner centering

PR validation:

Tried with workflow of 3 different scenario of Phase2 geometry D28, D31 and D41

if this PR is a backport please specify the original PR:

Needed for the next set of changes

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27122/10240

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/789/console Started: 2019/06/05 22:56

[cmsbuild]

-1

Tested at: 562b6e9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4decca/789/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-05-1100/src/Geometry/HGCalCommonData/src/HGCalDDDConstants.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-05-1100/src/Geometry/HGCalCommonData/src/FastTimeParameters.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-05-1100/src/Geometry/HGCalCommonData/src/HGCalWaferType.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-05-1100/src/Geometry/HGCalCommonData/src/FastTimeDDDConstants.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-05-1100/src/Geometry/HGCalCommonData/src/HGCalGeomTools.cc:1:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-05-1100/src/Geometry/HGCalCommonData/interface/HGCalGeomTools.h:48:27: error: constexpr variable 'factor_' must be initialized by a constant expression
  static constexpr double factor_ = 1.0/std::sqrt(3.0);
                          ^         ~~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-05-1100/src/Geometry/HGCalCommonData/interface/HGCalGeomTools.h:48:41: note: non-constexpr function 'sqrt' cannot be used in a constant expression
  static constexpr double factor_ = 1.0/std::sqrt(3.0);
                                        ^


[cmsbuild]

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27122/10285

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #27122 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/836/console Started: 2019/06/07 18:56

[cmsbuild]

+1
Tested at: a418edd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4decca/836/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4decca/836/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3215458
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215123
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[kpedro88]

+upgrade

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1