Fix hcalFraction definition in DeepTauID

[mbluj]

PR description:

This PR fixes issue related to the fact that DeepTauID is trained with samples produced before pat::PackedCandidate::hcalFraction() was redefined in #26506 (for >=CMSSW_10_6_X).
This fix is similar to one for RecoBTag/FeatureTools/plugins/DeepBoostedJetTagInfoProducer.cc
from #26506.

This fixes differences wrt DeepTauID with 10_2_X mentioned in #27148 (comment)

PR validation:

As it is a small and well focused change only a simple test running DeepTauID was executed.

if this PR is a backport please specify the original PR:

N/A

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27173/10324

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

RecoTauTag/RecoTau

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/874/console Started: 2019/06/11 16:57

[cmsbuild]

+1
Tested at: a18be00
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54410/874/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Phase2-hgx197 Test geometry for HFNose and also TB setups #27121 @bsunanda: Phase2-hgx197 Test geometry for HFNose and also TB setups
• Phase2-hgx198 preparing for corner centered wafers #27122 @bsunanda: Phase2-hgx198 preparing for corner centered wafers
• [HGCal] Material budget from vertex up to in front of muon stations #27126 @apsallid: [HGCal] Material budget from vertex up to in front of muon stations

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54410/874/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54410/874/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54410/874/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 94 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3215458
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215122
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

@mbluj , since you are fixing, could you please also include here (and in the backport) the fix suggested by the static analyzer in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54410/874/llvm-analysis/report-b3bc51.html#EndPath (that I evidently overlooked during previous review)?

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/899/console Started: 2019/06/12 12:06

[cmsbuild]

+1
Tested at: ca4e44c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54410/899/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54410/899/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 90 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3237932
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3237597
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

Please @mbluj confirm that the changes observed in the miniAOD outputs are the expected consequence of the fix, and that they now correspond identically to the outputs of the version of this code run in 10_2_X.

[mbluj]

Please @mbluj confirm that the changes observed in the miniAOD outputs are the expected consequence of the fix, and that they now correspond identically to the outputs of the version of this code run in 10_2_X.

DQM should not show differences as tauIDs are not yet monitored at MiniAOD and only small changes in DeepTauIDs embedded into pat::Taus in slimmedTaus collection are expected. And indeed the only differences reported by DQM tests, as far as I can see, are small differences by TimerService.

It was verified with a standalone tool that the fix makes DeepTauIDs identical between 106X/110X and 102X.

[perrotta]

Please @mbluj confirm that the changes observed in the miniAOD outputs are the expected consequence of the fix, and that they now correspond identically to the outputs of the version of this code run in 10_2_X.

DQM should not show differences as tauIDs are not yet monitored at MiniAOD and only small changes in DeepTauIDs embedded into pat::Taus in slimmedTaus collection are expected. And indeed the only differences reported by DQM tests, as far as I can see, are small differences by TimerService.

Well, the miniAOD event output comparison show differences, see https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_0_X_2019-06-11-2300+a54410/32208/validateJR.html, and this must be expected given the fix

It was verified with a standalone tool that the fix makes DeepTauIDs identical between 106X/110X and 102X.

Great! That was needed just to confirm it.

[mbluj]

Please @mbluj confirm that the changes observed in the miniAOD outputs are the expected consequence of the fix, and that they now correspond identically to the outputs of the version of this code run in 10_2_X.

DQM should not show differences as tauIDs are not yet monitored at MiniAOD and only small changes in DeepTauIDs embedded into pat::Taus in slimmedTaus collection are expected. And indeed the only differences reported by DQM tests, as far as I can see, are small differences by TimerService.

Well, the miniAOD event output comparison show differences, see https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_0_X_2019-06-11-2300+a54410/32208/validateJR.html, and this must be expected given the fix

It was verified with a standalone tool that the fix makes DeepTauIDs identical between 106X/110X and 102X.

Great! That was needed just to confirm it.

Sorry, I did not found these plots. Yes, they generally look as one can expect for comparisons with very low number of events. And as already said it was verified with bigger stats using standalone tools that changes are as expected.

[perrotta]

+1

• Fix needed to take into account the new hcal energy fractions defined in Add more calorimeter energy fractions to PackedCandidates #26506
• Changes in the tau IDs propagate to the miniAOD output: they are checked by the proponents to be as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1