zeroing PF clustering uncertainty

[Sam-Harper]

PR description:

This PR zeros out the PF cluster uncertainty by default as discussed in the PPD general meeting last week. This because those values are not used anywhere, do not really make sense and will for the 2017UL be inaccurate in the endcap.

This is a super minor thing and should not hold anything. If it gets in it gets in, if it doesnt , it doesnt.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27182/10337

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @felicepantaleo, @cbernet, @rovere, @lgray, @bachtis, @hatakeyamak, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/904/console Started: 2019/06/12 14:51

[cmsbuild]

-1

Tested at: 048c7a9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e2bb/904/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation warning when building: See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[perrotta]

This was added twice, instead of "setEnergyUncertainty"

[Sam-Harper]

urgh, yes this came from the fact I had to rebase back to 11_X due to code formats :(

[Sam-Harper]

thanks fixed now

[Sam-Harper]

They were file IO errors. Which is good because this PR is really not important and it hadnt been a file IO error I would have simply just closed it and not bothered

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/938/console Started: 2019/06/13 13:39

[cmsbuild]

+1
Tested at: f929234
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e2bb/938/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49e2bb/938/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 88 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3254096
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3253761
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• It zeroes out the PF cluster uncertainty by default, following a decision taken in the PPD general meeting
• Outputs show all correctedEnergyUncertanty'es zeroed, for all EGamma related clusters, as expected

@franzoni (+Phat, for whom I'm not able to find the github nickname...)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1