Revert "Add some reset calls to TrackingMonitorClient."

[schneiml]

This reverts commit a0c43f3.

PR description:

@mmusich suspects that this is causing too many plots to be reset. So let's try without it.
This might cause double counting in other places, lets see.

PR validation:

none.

if this PR is a backport please specify the original PR:

Needs forward port if tests agree.

[schneiml]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1009/console Started: 2019/06/18 17:52

[cmsbuild]

A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_10_6_X.

It involves the following packages:

DQM/TrackingMonitorClient

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @mtosi, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[mmusich]

thanks @schneiml but is not only me to have this suspicion .
We are running some other tests without the lines and see what happens.
Let me add @jandrea @hbecerri and @arossi83

[mmusich]

see also ongoing thread at: https://hypernews.cern.ch/HyperNews/CMS/get/dqmDevel/2412/1/2/1.html

[mmusich]

@schneiml is there a master PR as well?

[schneiml]

@mmusich no master PR for now, we'll need to decide if we go with this or #27239 based on the test results. I hope the PR tests actually do something useful on these plots.

[mmusich]

@schneiml I am sorry, but I don't follow how you actually validate the improvement. You won't see it in standard relval tests.

[cmsbuild]

+1
Tested at: 79a734d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63d045/1009/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63d045/1009/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3208236
• DQMHistoTests: Total failures: 198
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3207704
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[schneiml]

http://tinyurl.com/y2m5mbxb shows the original, filled state. Since #27239 does the same but more cleanly, let's go with that.