DQM/Tracking: Improve the per-lumi fix [10_6_X]

[schneiml]

PR description:

The fix for double counting in a0c43f3 seems to be a bit aggressive. It seems to have reset some MEs that are not per-lumi, so check for that.

PR validation:

Bin-to-bin comparison shows the plots in question re-populated.

if this PR is a backport please specify the original PR:

This is used instead of #27237, and a backport of #27246.

[schneiml]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1010/console Started: 2019/06/18 18:06

[cmsbuild]

A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_10_6_X.

It involves the following packages:

DQM/TrackingMonitorClient

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @mtosi, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 11312a0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d7696/1010/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d7696/1010/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3208236
• DQMHistoTests: Total failures: 197
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3207705
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[mtosi]

yes, thanks !
I’m afraid the current checks miss the Client to be run, though

[fioriNTU]

I would vote this solution and drop #27237. @mtosi, you are right, the clients are not tested in the current procedure, but probably @hbecerri can perform a quick private test, I know he has everything in place for it.

[schneiml]

Looks good, I'd say: http://tinyurl.com/yyanjesa

The changes seem identical between the two PRs, but then it is well possible that we don't run all the features in the PR tests.

[fabiocos]

@schneiml @fioriNTU please recall that before discussing backports we need to have a PR in master.

[schneiml]

@fabiocos so far these where only experiments.

[hbecerri]

Hello @fioriNTU, I did the test in my own terminal and the plots look good with the new changes.

[mmusich]

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU
what is preventing this from beign signed?

[mmusich]

gentle reminder, shall this be signed as well?

[fioriNTU]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

as requested by Tracker/Tracking and PPD