Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent pLHE workflows to start from input files #27285

Merged
merged 3 commits into from Jun 22, 2019
Merged

Prevent pLHE workflows to start from input files #27285

merged 3 commits into from Jun 22, 2019

Conversation

fabiocos
Copy link
Contributor

PR description:

PR #26875 has added 6 new test workflows based on pLHE input to GEN-SIM. Although the basic workflows run smoothly, when the -i all is used for runTheMatrix.py in IB , 1370.0,1370.17 and 1370.18 fail due to the fact that the generator part is split in two, and the standard logic of PyReleaseValidation fail, see issue #27248. A simple workaround is to force these workflows to be always fully executed, regardless of the input option (to be verified the possible impact on resources).

PR validation:

All the pLHE workflows have been verified to pass the first two steps both with and without the -i all option of runTheMatrix.py.

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Jun 20, 2019
@fabiocos fabiocos mentioned this pull request Jun 20, 2019
Closed
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27285/10492

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test workflow 1370.0,25215.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1074/console Started: 2019/06/20 14:01

@fabiocos
Copy link
Contributor Author

please abort

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27285/10494

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

Pull request #27285 was updated. @pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please check and sign again.

@fabiocos
Copy link
Contributor Author

please test workflow 1370.0,1370.17,1370.18,25215.0,25215.17,25215.18

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1075/console Started: 2019/06/20 14:11

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabiocos
Copy link
Contributor Author

obviously much faster...

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb4f1d/1096/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-fb4f1d/1370.0_GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13+GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13+Hadronizer_TuneCUETP8M1_13TeV_powhegEmissionVeto_2p_HToGG_M125_13+DIGIUP15+RECOUP15+HARVESTUP15
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-fb4f1d/1370.17_GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13UP17+GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13UP17+Hadronizer_TuneCUETP8M1_13TeV_powhegEmissionVeto_2p_HToGG_M125_13UP17+DIGIUP17+RECOUP17+HARVESTUP17
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-fb4f1d/1370.18_GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13UP18+GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13UP18+Hadronizer_TuneCUETP8M1_13TeV_powhegEmissionVeto_2p_HToGG_M125_13UP18+DIGIUP18+RECOUP18+HARVESTUP18
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-fb4f1d/25215.0_GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13+GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13+Hadronizer_TuneCUETP8M1_13TeV_powhegEmissionVeto_2p_HToGG_M125_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-fb4f1d/25215.17_GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13UP17+GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13UP17+Hadronizer_TuneCUETP8M1_13TeV_powhegEmissionVeto_2p_HToGG_M125_13UP17+DIGIUP17_PU25+RECOUP17_PU25+HARVESTUP17_PU25
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-fb4f1d/25215.18_GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13UP18+GluGluHToGG_M125_Pow_MINLO_NNLOPS_py8_13UP18+Hadronizer_TuneCUETP8M1_13TeV_powhegEmissionVeto_2p_HToGG_M125_13UP18+DIGIUP18_PU25+RECOUP18_PU25+HARVESTUP18_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254586
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3254251
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor Author

@prebello @zhenhu @kpedro88 I take the previous signature as valid, the only change is the number of events processed in the LHE and GEN,SIM steps (irrelevant for the final DQM result, but important for the performance impact on the tests).

Please check and sign or comment otherwise, I want to give this PR a try in next IB, before the big Sunday rebuild

@fabiocos
Copy link
Contributor Author

+1

@fabiocos
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit c02ca2d into cms-sw:master Jun 22, 2019
@cmsbuild cmsbuild mentioned this pull request Jun 22, 2019
Merged
@zhenhu
Copy link
Contributor

zhenhu commented Jun 22, 2019

+1

This was referenced Jun 22, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@fabiocos fabiocos deleted the fc-fix26875 branch August 7, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available orp-approved pdmv-approved pending-signatures tests-approved upgrade-pending
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fabiocos @cmsbuild @prebello @kpedro88 @smuzaffar @zhenhu