Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCal trigger support for Fireworks #27304

Merged
merged 10 commits into from Jun 22, 2019
Merged

HGCal trigger support for Fireworks #27304

merged 10 commits into from Jun 22, 2019

Conversation

Mourtz
Copy link
Contributor

@Mourtz Mourtz commented Jun 21, 2019

Add support for HGCAL L1 Trigger in Fireworks.

@rovere @cerminar

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27304/10527

  • This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27304/10528

  • This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@fabiocos
Copy link
Contributor

@Mourtz sorry, could you please give to this PR a more informative title?

@Mourtz Mourtz changed the title L1 trigger HGCal trigger support for Fireworks Jun 21, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 21, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1101/console Started: 2019/06/21 18:58

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants