Running code-format for reconstruction #27350
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27350/10614
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @cmsbuild for master. It involves the following packages: RecoEgamma/EgammaTools @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| mutable unsigned ele_idx,pho_idx; // hack here until we figure out why some slimmedPhotons don't have original object ptrs | ||
| std::unordered_map<unsigned, edm::Handle<edm::ValueMap<MapType>>> pho_vmaps; | ||
| mutable unsigned ele_idx, | ||
| pho_idx; // hack here until we figure out why some slimmedPhotons don't have original object ptrs |
There was a problem hiding this comment.
comment-related line break issue
| fVals[59] = biphi % 2; //submodule boundary phi symmetry | ||
| fVals[60] = (TMath::Abs(bieta) <= 25) * (bieta % 25) + | ||
| (TMath::Abs(bieta) > 25) * | ||
| ((bieta - 25 * TMath::Abs(bieta) / bieta) % 20); //module boundary eta approximate symmetry |
There was a problem hiding this comment.
comment-related line break issue
| fVals[33] = biphi % 2; //submodule boundary phi symmetry | ||
| fVals[34] = (TMath::Abs(bieta) <= 25) * (bieta % 25) + | ||
| (TMath::Abs(bieta) > 25) * | ||
| ((bieta - 25 * TMath::Abs(bieta) / bieta) % 20); //module boundary eta approximate symmetry |
There was a problem hiding this comment.
comment-related line break issue; probably
| fVals[15] = TMath::Min(1.0, 1.0022 * p.e5x5() / b->energy()); | ||
|
|
||
| fVals[4] = | ||
| fVals[15] * b->energy() / s->rawEnergy(); // compute consistent e5x5()/rawEnergy() after e5x5/eseed resacling |
There was a problem hiding this comment.
comment-related line break issue
| fVals[5] = 0.903254 * s->etaWidth() + 0.001346; //etawidth | ||
| fVals[6] = 0.99992 * s->phiWidth() + 4.8e-07; //phiwidth | ||
| fVals[13] = | ||
| TMath::Min(1.0, 1.0022 * b->energy() / s->rawEnergy()); //eseed/rawenergy (practically equivalent to e5x5) |
There was a problem hiding this comment.
comment-related line break issue
| double ecalClusterEnergyCalibrated = | ||
| sqrt(std::get<1>(ecalSatellite.second).Mag2()) * | ||
| std::get<2>( | ||
| ecalSatellite.second); // KH: calibrated under the egamma hypothesis (rawEcalClusterEnergy * calibration) |
There was a problem hiding this comment.
comment-related line break issue
|
|
||
| double hoEnergy = hoclusterRef->energy(); // calibration_.energyEm(*hoclusterRef,ps1Ene,ps2Ene,crackCorrection); | ||
| double hoEnergy = | ||
| hoclusterRef->energy(); // calibration_.energyEm(*hoclusterRef,ps1Ene,ps2Ene,crackCorrection); |
There was a problem hiding this comment.
comment-related line break issue
| size_t convkfs_end = std::distance(BeginROskfs, ronotconv); | ||
| for (size_t idx = 0; idx < convkfs_end; ++idx) { | ||
| auto const& secKFs = | ||
| RO.secondaryKFs; //we want the entry at the index but we allocate to secondaryKFs in loop which invalidates all iterators, references and pointers, hence we need to get the entry fresh each time |
There was a problem hiding this comment.
comment-related line break issue
| eventFractionCleaning_(getParameter<double>(iConfig, "eventFractionForCleaning", 0.75)), | ||
| dzPV_(getParameter<double>(iConfig, "dzPV", 0.2)), | ||
| postCleaning_(getParameter<bool>(iConfig, "postMuonCleaning", false)) // disable by default (for HLT) | ||
| , |
There was a problem hiding this comment.
comment-related line break issue
| pfPunchThroughHadronCleanedCandidates_(std::make_unique<reco::PFCandidateCollection>()), | ||
| pfAddedMuonCandidates_(std::make_unique<reco::PFCandidateCollection>()) | ||
|
|
||
| , |
There was a problem hiding this comment.
this could be moved up to avoid the empty line
|
+1
Issues reported in |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Applying code-format for CMSSW category reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/430//console
cms-bot has successfully run the following: