New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecoEgamma/ElectronIdentification cleanup #27370
RecoEgamma/ElectronIdentification cleanup #27370
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27370/10644
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: PhysicsTools/SelectorUtils @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
thank you @guitargeek ! This is much appreciated! |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is one of the occasional PRs that removes old electron IDs as the goal is still to have only the VIDs and other currently used IDs left in the release. This time, I remove the old Likelihood based IDs and some old cut based IDs. One working point is still used in PF, so I move it there.
@Sam-Harper
PR validation:
CMSSW compiles and local matrix tests pass.
if this PR is a backport please specify the original PR:
No backport intended.